Review main Merged

64190[BUGFIX] Provide symfony container in install tool "Check TCA" action

Benjamin Franzke CR +2 V +2 Easy +11 −7 updated 04/17/20, 05:08

Commit message

A booted symfony container is needed as ext_localconf.php is
loaded since #89713 for the "Check TCA" action.
ext_localconf.php files may depend on a fully-booted
symfony container, therefore we need to provide it in this
case as well – or ext_localconf.php loading may fail.

Adapt the LateBootService to allow to reset to a
previously backuped container (even if it has been
reset in the meantime by another method).

Currently affected extensions were EXT:news before commit
ac0cb20c (which added a workaround for this case).
Thus the bugfix can be verified against the parent of that commit:
georgringer/news:205cb3e

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Josef Glatz +1
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 2

Files 2

Review log 712

  1. Benjamin Franzke uploaded patch set 1 04/15/20, 17:20

  2. TYPO3com voted on patch set 1 V -1 04/15/20, 17:33 Completed build in 13m 26s on Wed, 15 Apr, 05:33 PM Test Summary: 1 of 74056 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2600

  3. TYPO3com voted on patch set 1 V +1 04/15/20, 18:21 Completed build in 16m 46s on Wed, 15 Apr, 06:21 PM Test Summary: 73571 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2604

  4. Benjamin Franzke wrote 04/16/20, 16:57

    Topic set to di
  5. Benjamin Franzke updated the commit message in patch set 2 04/16/20, 23:10

  6. TYPO3com voted on patch set 2 V -1 04/16/20, 23:27 Completed build in 16m 13s on Thu, 16 Apr, 11:27 PM Test Summary: 73240 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2676

  7. TYPO3com commented on patch set 2 04/16/20, 23:42 Completed build in 15m 29s on Thu, 16 Apr, 11:42 PM Test Summary: 73549 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2677

  8. TYPO3com voted on patch set 2 V +1 04/17/20, 00:13 Completed build in 11m 31s on Fri, 17 Apr, 12:13 AM Test Summary: 73561 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2678

  9. Josef Glatz commented on patch set 2 V +1 04/17/20, 04:32

    Verified with the mentioned commit hash from georgringer/news:205cb3e. * "Check TCA in ext_tables.php" doesn't throw an exception. * Tested in non-composer environment
  10. Georg Ringer voted on patch set 2 V +1 CR +1 04/17/20, 04:49

  11. Andreas Kienast voted on patch set 2 V +2 CR +2 04/17/20, 05:08

  12. Andreas Kienast merged patch set 3 04/17/20, 05:08