64191[TASK] Reduce inline `onchange` events in backend scope
Commit message
Review
-
Code review CR -1 Done
- Oliver Hader +2
- Georg Ringer -1
- Benni Mack +1
-
Verified V +2 Done
- Oliver Hader +2
- Benni Mack +1
- TYPO3com +1 CI
Issues 1
Files 7
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/GlobalEventHandler.tsnew+125 −0
- typo3/sysext/backend/Classes/Template/ModuleTemplate.php+1 −0
- typo3/sysext/backend/Resources/Private/Partials/Menus/SelectBoxJumpMenu.html+4 −1
- typo3/sysext/backend/Resources/Public/JavaScript/GlobalEventHandler.jsnew+13 −0
- typo3/sysext/belog/Classes/Controller/BackendLogController.php+4 −6
- typo3/sysext/belog/Resources/Private/Partials/Content/Filter.html3+7 −7
- typo3/sysext/indexed_search/Resources/Private/Templates/Administration/Statistic.html+2 −2
Review log 1727
Show 12 earlier messages
-
Oliver Hader uploaded patch set 1 04/15/20, 17:35
-
TYPO3com voted on patch set 1 V -1 04/15/20, 17:50 Completed build in 15m 31s on Wed, 15 Apr, 05:50 PM Test Summary: 2 of 74055 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2601
-
TYPO3com commented on patch set 1 04/15/20, 19:35 Completed build in 2h 16m 02s on Wed, 15 Apr, 07:35 PM Test Summary: 73571 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2601
-
TYPO3com commented on patch set 1 04/15/20, 20:48 Completed build in 5h 29m 33s on Wed, 15 Apr, 08:48 PM Test Summary: 73571 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2601
-
TYPO3com commented on patch set 1 04/15/20, 20:53 Completed build in 8h 47m 59s on Wed, 15 Apr, 08:53 PM Test Summary: 73571 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2601
-
Oliver Hader rebased onto patch set 2 04/15/20, 20:54
-
Oliver Hader uploaded patch set 3 04/15/20, 20:55
-
TYPO3com voted on patch set 2 V -1 04/15/20, 21:13 Completed build in 17m 01s on Wed, 15 Apr, 09:13 PM Test Summary: 73571 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2614
-
TYPO3com voted on patch set 3 V +1 04/15/20, 21:15 Completed build in 18m 52s on Wed, 15 Apr, 09:15 PM Test Summary: 73571 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2615
-
Oliver Hader voted on patch set 3 CR -1 04/16/20, 12:50
-
Oliver Hader uploaded patch set 4 04/16/20, 14:11
-
TYPO3com voted on patch set 4 V -1 04/16/20, 14:24 Completed build in 12m 31s on Thu, 16 Apr, 02:24 PM Test Summary: 12 of 74045 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2650
-
Oliver Hader uploaded patch set 5 04/16/20, 14:33
-
TYPO3com voted on patch set 5 V -1 04/16/20, 14:45 Completed build in 11m 52s on Thu, 16 Apr, 02:45 PM Test Summary: 73240 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2652
-
TYPO3com voted on patch set 5 V +1 04/16/20, 15:49 Completed build in 1h 27m 22s on Thu, 16 Apr, 03:49 PM Test Summary: 73561 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2652
-
Oliver Klee commented on patch set 5 04/16/20, 16:20
-
Oliver Hader rebased onto patch set 6 04/16/20, 17:11
-
Oliver Hader commented on patch set 6 04/16/20, 17:13
> Patch Set 5: > > (1 comment) https://review.typo3.org/c/Packages/TYPO3.CMS/+/64191/5/typo3/sysext/belog/Classes/Controller/BackendLogController.php Actually it's removing the superfluous definition... (including the wrong type-hint ;-) ) -
TYPO3com voted on patch set 6 V +1 04/16/20, 17:22 Completed build in 11m 24s on Thu, 16 Apr, 05:22 PM Test Summary: 73561 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2659
-
Oliver Klee commented on patch set 6 04/16/20, 17:59
> Actually it's removing the superfluous definition... (including the wrong type-hint ;-) ) Ah, okay. :-) -
Benni Mack voted on patch set 6 V +1 04/16/20, 19:57
-
Benni Mack voted on patch set 6 CR +1 04/16/20, 20:00
-
Georg Ringer commented on patch set 6 CR -1 04/16/20, 20:05
Filter.html:23any reason why not using data="{global-event:'change',action-submit:'$form'}? -
Oliver Hader commented on patch set 6 V +2 CR +2 04/16/20, 20:19
Filter.html:23ReplyBecause it's an attribute instead of a dataset map in JavaScript... In case we still want to do it, it's a simple search/replace over the whole core... -
Oliver Hader merged patch set 7 04/16/20, 20:19
-
Oliver Hader commented on patch set 7 04/16/20, 20:28
Filter.html:23Reply UnresolvedAh, misread that... thought it's about `data-`, but it's about Fluid notation... still should be easy to adjust that -
Oliver Hader wrote 04/18/20, 12:37
Topic set to inline-javascript
Unresolved