Review main Merged

64192[TASK] Include all classes via use statements in ext:core

Benni Mack CR +2 V +2 Expert +1318 −776 updated 04/16/20, 19:03

Commit message

This patch has been created with rector and php-cs-fixer

    bin/rector process --set=php53 typo3/sysext/core/Classes
    bin/rector process --set=php53 typo3/sysext/core/Tests

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Alexander Schnitzler +1
  • Verified V +2 Done
    • Susi Moog +2
    • Alexander Schnitzler +1
    • TYPO3com +1 CI

Issues 1

Files 240

Show 220 more files

Review log 1519

  1. Benni Mack uploaded patch set 1 04/15/20, 20:24

  2. TYPO3com voted on patch set 1 V +1 04/15/20, 20:37 Completed build in 12m 55s on Wed, 15 Apr, 08:37 PM Test Summary: 73569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2608

  3. Benni Mack uploaded patch set 2 04/15/20, 20:48

  4. Benni Mack commented on patch set 2 CR -1 04/15/20, 20:50

    Crap. This also took the ext_localconf.php files with it
  5. Benni Mack uploaded patch set 3 04/15/20, 20:55

  6. TYPO3com voted on patch set 2 V +1 04/15/20, 21:01 Completed build in 13m 26s on Wed, 15 Apr, 09:01 PM Test Summary: 73571 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2612

  7. TYPO3com voted on patch set 3 V +1 04/15/20, 21:19 Completed build in 23m 07s on Wed, 15 Apr, 09:19 PM Test Summary: 73571 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2616

  8. Georg Ringer voted on patch set 3 V +1 CR +1 04/16/20, 04:45

  9. Josef Glatz commented on patch set 3 CR -1 04/16/20, 06:05

    Folks, is it correct that if I run the two commands locally that I get many changes like: - comments which are no PHPDoc blocks (at least it looks like) - array intendations - spaces in parameter's PHPDoc block lines after commas are changed Do I have to worry or did you select all specific changes manually before commiting them.
  10. Alexander Schnitzler commented on patch set 3 04/16/20, 06:49

    > Patch Set 3: Code-Review-1 > > Folks, is it correct that if I run the two commands locally that I get many changes like: > - comments which are no PHPDoc blocks (at least it looks like) > - array intendations > - spaces in parameter's PHPDoc block lines after commas are changed > > Do I have to worry or did you select all specific changes manually before commiting them. Did you by accident not run a composer install which updates rector to the latest version? The rector version we had before, had many bugs with wrong changes. To answer your question. The patches are created just by running rector, no manual adjustments.
  11. Alexander Schnitzler uploaded patch set 4 04/16/20, 08:01

  12. Benjamin Franzke commented on patch set 4 04/16/20, 08:10

    > To answer your question. The patches are created just by running rector, no manual adjustments. For me, even with updated dependencies and patchset 4 there is a slight diff when running rector: https://bnf.dev/~ben/uploads/32ec3/typo3-patch-64192-rector-diff Benni, did you manually exclude these changes?
  13. TYPO3com voted on patch set 4 V +1 04/16/20, 08:18 Completed build in 14m 05s on Thu, 16 Apr, 08:18 AM Test Summary: 73571 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2638

  14. Alexander Schnitzler commented on patch set 4 04/16/20, 08:30

    > Patch Set 4: > > > To answer your question. The patches are created just by running rector, no manual adjustments. > > For me, even with updated dependencies and patchset 4 there is a slight diff when running rector: > https://bnf.dev/~ben/uploads/32ec3/typo3-patch-64192-rector-diff > Benni, did you manually exclude these changes? Sorry, my mistake. For ext:core, rector actually changes more than necessary. That's one of the issues I currently see with rector in general. You cannot really run it completely side effect free at the moment. But for the most parts it does what it should.
  15. Alexander Schnitzler voted on patch set 4 V +1 CR +1 04/16/20, 09:43

  16. Susi Moog voted on patch set 4 V +2 CR +2 04/16/20, 12:41

  17. Susi Moog merged patch set 5 04/16/20, 12:42

  18. Josef Glatz commented on patch set 5 04/16/20, 14:15

    > just for the records, for later, if somebody wonders why there are changes which aren't commited in this patch: the following gist shows the intentionally leftover changes https://gist.github.com/josefglatz/58f2f32e0d2de473e6bf8c29af779be7
  19. Alexander Schnitzler commented on patch set 5 04/16/20, 19:03

    > Patch Set 5: > > > just for the records, for later, if somebody wonders why there are changes which aren't commited in this patch: the following gist shows the intentionally leftover changes https://gist.github.com/josefglatz/58f2f32e0d2de473e6bf8c29af779be7 There are a lot of missing imports in your gist. We will add those missing use statements in a last minute patch.