Review main Merged

64198[TASK] Disable rector for ServiceProviders to avoid auto_import_names

Benjamin Franzke CR +2 V +2 Normal +30 −37 updated 04/16/20, 07:54

Commit message

rectors `auto_import_names` causes relative class names to
be transformed into `use` statements.
This reduces the readability of the grouped
getFactories array as used in ServiceProviders, we rather used
to define all external dependencies in use statements and
to include local dependencies using relative class names.

Also revert the change in TYPO3\CMS\Extbase\ServiceProvider
which has already been applied in #91047 using:
  git checkout 682873dd61ccd398bcf58b1e76133b638cf5ecf9^ -- \
    typo3/sysext/extbase/Classes/ServiceProvider.php

Review

  • Code review CR +2 Done
    • Alexander Schnitzler +2
  • Verified V +2 Done
    • Alexander Schnitzler +2
    • TYPO3com +1 CI

Issues 2

Files 2

Review log 811

  1. Benjamin Franzke uploaded patch set 1 04/16/20, 07:28

  2. Benjamin Franzke uploaded patch set 2 04/16/20, 07:30

  3. Alexander Schnitzler commented on patch set 2 V +1 CR +1 04/16/20, 07:34

    +1 except for the commit message
    impot -> import
    recotrs -> rectors
  4. Benjamin Franzke updated the commit message in patch set 3 04/16/20, 07:38

  5. Benjamin Franzke commented on patch set 3 04/16/20, 07:38

    Reply

    Done

    Reply

    Done
  6. TYPO3com voted on patch set 1 V +1 04/16/20, 07:40 Completed build in 11m 48s on Thu, 16 Apr, 07:40 AM Test Summary: 73571 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2633

  7. Alexander Schnitzler voted on patch set 3 V +1 CR +1 04/16/20, 07:42

  8. TYPO3com voted on patch set 2 V +1 04/16/20, 07:45 Completed build in 15m 30s on Thu, 16 Apr, 07:45 AM Test Summary: 73571 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2634

  9. TYPO3com voted on patch set 3 V +1 04/16/20, 07:50 Completed build in 12m 00s on Thu, 16 Apr, 07:50 AM Test Summary: 73571 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2635

  10. Alexander Schnitzler voted on patch set 3 V +2 CR +2 04/16/20, 07:54

  11. Alexander Schnitzler merged patch set 4 04/16/20, 07:54