Review main Merged

64199[TASK] Mark various functionality in TSFE internal

Benni Mack CR +2 V +2 Normal +56 −0 updated 04/17/20, 14:12

Commit message

Some code related to templating / cached TypoScript,
inclusion of CSS/JS and internals like "indexedDocTitle"
which has now a proper PageTitle API, is marked as
internal now, so further refactorings can happen
in the next major release.

As all replacements are in place for this functionality,
extension authors can and should already use new APIs
instead of relying on TSFE for this logic.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Susi Moog +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 811

  1. Benni Mack uploaded patch set 1 04/16/20, 09:15

  2. TYPO3com voted on patch set 1 V +1 04/16/20, 09:27 Completed build in 11m 52s on Thu, 16 Apr, 09:27 AM Test Summary: 73559 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2642

  3. Benni Mack uploaded patch set 2 04/17/20, 07:39

  4. TYPO3com voted on patch set 2 V +1 04/17/20, 07:55 Completed build in 16m 06s on Fri, 17 Apr, 07:55 AM Test Summary: 73561 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2690

  5. Oliver Klee voted on patch set 2 CR +1 04/17/20, 07:57

  6. Christian Eßl voted on patch set 2 CR +1 04/17/20, 11:17

  7. Susi Moog commented on patch set 3 04/17/20, 13:58

    Published edit on patch set 2.
  8. Susi Moog voted on patch set 3 V +1 CR +1 04/17/20, 13:58

  9. TYPO3com voted on patch set 3 V +1 04/17/20, 14:12 Completed build in 14m 01s on Fri, 17 Apr, 02:12 PM Test Summary: 73567 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2729

  10. Andreas Kienast voted on patch set 3 V +2 CR +2 04/17/20, 14:12

  11. Andreas Kienast merged patch set 4 04/17/20, 14:12