64201[!!!][TASK] Move interfaces of dashboard
Commit message
Review
-
Code review CR +2 Done
- Richard Haeser +2
- Benni Mack +1
-
Verified V +2 Done
- Richard Haeser +2
- Benni Mack +1
- TYPO3com +1 CI
Issues 1
Files 37
- typo3/sysext/core/Documentation/Changelog/master/Breaking-91066-MovedInterfacesOfDashboard.rstnew+43 −0
- typo3/sysext/core/Documentation/Changelog/master/Breaking-91066-RemovedButtonUtility.rstnew+56 −0
- typo3/sysext/dashboard/Classes/Controller/WidgetAjaxController.php+2 −2
- typo3/sysext/dashboard/Classes/Utility/ButtonUtility.phpdeleted+0 −36
- typo3/sysext/dashboard/Classes/Widgets/Provider/ButtonProvider.php+1 −1
- typo3/sysext/dashboard/Classes/Widgets/Provider/NumberOfFailedLoginsDataProvider.php+1 −1
- typo3/sysext/dashboard/Classes/Widgets/Provider/SysLogButtonProvider.php+1 −1
- typo3/sysext/dashboard/Classes/Widgets/Provider/SysLogErrorsDataProvider.php+1 −1
- typo3/sysext/dashboard/Classes/Widgets/Provider/TypeOfUsersChartDataProvider.php+1 −1
- typo3/sysext/dashboard/Classes/Widgets/AdditionalCssInterface.phprenamed+1 −1
- typo3/sysext/dashboard/Classes/Widgets/AdditionalJavaScriptInterface.phprenamed+1 −1
- typo3/sysext/dashboard/Classes/Widgets/BarChartWidget.php+1 −9
- typo3/sysext/dashboard/Classes/Widgets/ButtonProviderInterface.phprenamed+1 −1
- typo3/sysext/dashboard/Classes/Widgets/ChartDataProviderInterface.phprenamed+1 −1
- typo3/sysext/dashboard/Classes/Widgets/CtaWidget.php+1 −5
- typo3/sysext/dashboard/Classes/Widgets/DoughnutChartWidget.php+1 −9
- typo3/sysext/dashboard/Classes/Widgets/EventDataInterface.phprenamed+1 −1
- typo3/sysext/dashboard/Classes/Widgets/ListDataProviderInterface.phprenamed+1 −1
- typo3/sysext/dashboard/Classes/Widgets/ListWidget.php+1 −6
- typo3/sysext/dashboard/Classes/Widgets/NumberWithIconDataProviderInterface.phprenamed+1 −1
Show 17 more files
- typo3/sysext/dashboard/Classes/Widgets/NumberWithIconWidget.php+0 −3
- typo3/sysext/dashboard/Classes/Widgets/RequireJsModuleInterface.phprenamed+1 −1
- typo3/sysext/dashboard/Classes/Widgets/RssWidget.php+1 −5
- typo3/sysext/dashboard/Classes/Widgets/T3GeneralInformationWidget.php+0 −2
- typo3/sysext/dashboard/Classes/Widgets/WidgetConfiguration.php+0 −2
- typo3/sysext/dashboard/Classes/Widgets/WidgetConfigurationInterface.phprenamed+1 −1
- typo3/sysext/dashboard/Classes/Widgets/WidgetInterface.phprenamed+1 −1
- typo3/sysext/dashboard/Classes/Dashboard.php+2 −2
- typo3/sysext/dashboard/Classes/DashboardInitializationService.php+3 −3
- typo3/sysext/dashboard/Classes/DashboardRepository.php+1 −1
- typo3/sysext/dashboard/Classes/WidgetRegistry.php+1 −1
- typo3/sysext/dashboard/Resources/Private/Templates/Widget/ChartWidget.html+1 −1
- typo3/sysext/dashboard/Resources/Private/Templates/Widget/CtaWidget.html+1 −1
- typo3/sysext/dashboard/Resources/Private/Templates/Widget/ListWidget.html+1 −1
- typo3/sysext/dashboard/Resources/Private/Templates/Widget/RssWidget.html+1 −1
- typo3/sysext/dashboard/Tests/Unit/WidgetRegistryTest.php+1 −1
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ClassNameMatcher.php+55 −0
Review log 68
-
Susi Moog uploaded patch set 1 04/16/20, 13:06
-
TYPO3com voted on patch set 1 V -1 04/16/20, 13:07 Completed build in 24s on Thu, 16 Apr, 01:07 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2648
-
Richard Haeser commented on patch set 1 CR -1 04/16/20, 13:15
This is a breaking change as interfaces are used by third-party widgets. Will update patch later today. -
Richard Haeser uploaded patch set 2 04/16/20, 20:39
-
TYPO3com voted on patch set 2 V +1 04/16/20, 20:52 Completed build in 12m 53s on Thu, 16 Apr, 08:52 PM Test Summary: 73561 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2664
-
Benni Mack commented on patch set 2 V +1 CR +1 04/16/20, 20:55
Thank you for consideration! -
Richard Haeser voted on patch set 2 V +2 CR +2 04/16/20, 21:13
-
Richard Haeser merged patch set 3 04/16/20, 21:13