64203[TASK] Use more specific array type annotations in GeneralUtility
Commit message
Review
-
Code review CR +2 Done
- Daniel Goerz +2
- Jonas Eberle +1
- Alexander Schnitzler +1
-
Verified V +2 Done
- Daniel Goerz +2
- Jonas Eberle +1
- Alexander Schnitzler +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 2230
Show 45 earlier messages
-
Oliver Klee uploaded patch set 1 04/16/20, 16:04
-
TYPO3com voted on patch set 1 V +1 04/16/20, 16:22 Completed build in 17m 27s on Thu, 16 Apr, 04:22 PM Test Summary: 73561 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2655
-
Anja Leichsenring voted on patch set 1 V +1 CR +1 04/16/20, 16:48
-
Alexander Schnitzler commented on patch set 1 04/16/20, 20:40
GeneralUtility.php:3581array<class-string, SingletonInterface> would be better for phpstan here.GeneralUtility.php:3597array<class-string, object> would be better for phpstan here. -
Oliver Klee commented on patch set 1 04/16/20, 20:44
Thanks for the remarks! I'll update the changeset in a minute.
-
Oliver Klee commented on patch set 1 04/16/20, 20:51
GeneralUtility.php:1255ReplyDoneGeneralUtility.php:3581ReplyDoneGeneralUtility.php:3597Reply UnresolvedIt's even array<class-string, array<object>>. Done. -
Oliver Klee uploaded patch set 2 04/16/20, 20:51
-
Oliver Klee uploaded patch set 3 04/16/20, 20:57
-
TYPO3com voted on patch set 2 V -1 04/16/20, 21:03 Completed build in 11m 43s on Thu, 16 Apr, 09:03 PM Test Summary: 73560 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2665
-
Benni Mack voted on patch set 3 CR +1 04/16/20, 21:10
-
TYPO3com voted on patch set 3 V -1 04/16/20, 21:15 Completed build in 15m 31s on Thu, 16 Apr, 09:15 PM Test Summary: 73561 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2667
-
Oliver Klee commented on patch set 3 04/16/20, 22:01
It looks like "class-string" is not a valid key type: An array can have only integers or strings as keys https://bamboo.typo3.com/browse/CORE-GTC-IDB-2667/log -
Oliver Klee uploaded patch set 4 04/16/20, 22:03
-
TYPO3com voted on patch set 4 V +1 04/16/20, 22:15 Completed build in 11m 45s on Thu, 16 Apr, 10:15 PM Test Summary: 73561 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2672
-
Oliver Klee commented on patch set 4 04/18/20, 07:38
Ping … this needs a re-review. -
Alexander Schnitzler uploaded patch set 5 04/18/20, 10:22
-
Alexander Schnitzler voted on patch set 5 V +1 CR +1 04/18/20, 10:22
-
TYPO3com voted on patch set 5 V -1 04/18/20, 10:41 Completed build in 19m 41s on Sat, 18 Apr, 10:41 AM Test Summary: 2 of 73456 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2780
-
TYPO3com voted on patch set 5 V +1 04/18/20, 10:52 Completed build in 50m 08s on Sat, 18 Apr, 10:52 AM Test Summary: 73626 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2780
-
Oliver Klee commented on patch set 5 04/18/20, 11:04
GeneralUtility.php:818This can be array<int,array<int,string>> instead (as the inner value is the result of a trim call). -
Oliver Klee uploaded patch set 6 04/18/20, 11:31
-
Oliver Klee commented on patch set 6 04/18/20, 11:32
GeneralUtility.php:818ReplyDone -
Alexander Schnitzler voted on patch set 6 V +1 CR +1 04/18/20, 11:36
-
Oliver Klee uploaded patch set 7 04/18/20, 11:45
-
Alexander Schnitzler voted on patch set 7 V +1 CR +1 04/18/20, 12:08
-
TYPO3com voted on patch set 6 V -1 04/18/20, 12:13 Completed build in 23m 17s on Sat, 18 Apr, 12:13 PM Test Summary: 1 of 74111 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2782
-
TYPO3com voted on patch set 7 V +1 04/18/20, 12:27 Completed build in 37m 15s on Sat, 18 Apr, 12:27 PM Test Summary: 73627 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2784
-
Jonas Eberle voted on patch set 7 V +1 CR +1 04/18/20, 13:50
-
Daniel Goerz voted on patch set 7 V +2 CR +2 04/19/20, 11:43
-
Daniel Goerz merged patch set 8 04/19/20, 11:43
GeneralUtility.php:1255