Review main Merged

64203[TASK] Use more specific array type annotations in GeneralUtility

Oliver Klee CR +2 V +2 Normal +29 −29 updated 04/19/20, 11:43

Commit message

Having PHPDoc parameter and return type annotations like "string[]"
instead of the generic "array" will help both static code analysers
as well as human readers.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Jonas Eberle +1
    • Alexander Schnitzler +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Jonas Eberle +1
    • Alexander Schnitzler +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 2230

Show 45 earlier messages
  1. Oliver Klee uploaded patch set 1 04/16/20, 16:04

  2. TYPO3com voted on patch set 1 V +1 04/16/20, 16:22 Completed build in 17m 27s on Thu, 16 Apr, 04:22 PM Test Summary: 73561 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2655

  3. Anja Leichsenring voted on patch set 1 V +1 CR +1 04/16/20, 16:48

  4. Alexander Schnitzler commented on patch set 1 04/16/20, 20:40

    GeneralUtility.php:1255

    array<string,string> would be even more precise here.

    GeneralUtility.php:3581

    array<class-string, SingletonInterface> would be better for phpstan here.

    GeneralUtility.php:3597

    array<class-string, object> would be better for phpstan here.
  5. Oliver Klee commented on patch set 1 04/16/20, 20:44

    Thanks for the remarks! I'll update the changeset in a minute.
  1. Oliver Klee commented on patch set 1 04/16/20, 20:51

    GeneralUtility.php:1255 Reply

    Done

    GeneralUtility.php:3581 Reply

    Done

    GeneralUtility.php:3597 Reply Unresolved

    It's even array<class-string, array<object>>. Done.
  2. Oliver Klee uploaded patch set 2 04/16/20, 20:51

  3. Oliver Klee uploaded patch set 3 04/16/20, 20:57

  4. TYPO3com voted on patch set 2 V -1 04/16/20, 21:03 Completed build in 11m 43s on Thu, 16 Apr, 09:03 PM Test Summary: 73560 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2665

  5. Benni Mack voted on patch set 3 CR +1 04/16/20, 21:10

  6. TYPO3com voted on patch set 3 V -1 04/16/20, 21:15 Completed build in 15m 31s on Thu, 16 Apr, 09:15 PM Test Summary: 73561 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2667

  7. Oliver Klee commented on patch set 3 04/16/20, 22:01

    It looks like "class-string" is not a valid key type: An array can have only integers or strings as keys https://bamboo.typo3.com/browse/CORE-GTC-IDB-2667/log
  8. Oliver Klee uploaded patch set 4 04/16/20, 22:03

  9. TYPO3com voted on patch set 4 V +1 04/16/20, 22:15 Completed build in 11m 45s on Thu, 16 Apr, 10:15 PM Test Summary: 73561 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2672

  10. Oliver Klee commented on patch set 4 04/18/20, 07:38

    Ping … this needs a re-review.
  11. Alexander Schnitzler uploaded patch set 5 04/18/20, 10:22

  12. Alexander Schnitzler voted on patch set 5 V +1 CR +1 04/18/20, 10:22

  13. TYPO3com voted on patch set 5 V -1 04/18/20, 10:41 Completed build in 19m 41s on Sat, 18 Apr, 10:41 AM Test Summary: 2 of 73456 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2780

  14. TYPO3com voted on patch set 5 V +1 04/18/20, 10:52 Completed build in 50m 08s on Sat, 18 Apr, 10:52 AM Test Summary: 73626 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2780

  15. Oliver Klee commented on patch set 5 04/18/20, 11:04

    GeneralUtility.php:818

    This can be array<int,array<int,string>> instead (as the inner value is the result of a trim call).
  16. Oliver Klee uploaded patch set 6 04/18/20, 11:31

  17. Oliver Klee commented on patch set 6 04/18/20, 11:32

    GeneralUtility.php:818 Reply

    Done
  18. Alexander Schnitzler voted on patch set 6 V +1 CR +1 04/18/20, 11:36

  19. Oliver Klee uploaded patch set 7 04/18/20, 11:45

  20. Alexander Schnitzler voted on patch set 7 V +1 CR +1 04/18/20, 12:08

  21. TYPO3com voted on patch set 6 V -1 04/18/20, 12:13 Completed build in 23m 17s on Sat, 18 Apr, 12:13 PM Test Summary: 1 of 74111 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2782

  22. TYPO3com voted on patch set 7 V +1 04/18/20, 12:27 Completed build in 37m 15s on Sat, 18 Apr, 12:27 PM Test Summary: 73627 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2784

  23. Jonas Eberle voted on patch set 7 V +1 CR +1 04/18/20, 13:50

  24. Daniel Goerz voted on patch set 7 V +2 CR +2 04/19/20, 11:43

  25. Daniel Goerz merged patch set 8 04/19/20, 11:43