Review main Merged

64204[BUGFIX] Add ext-libxml to composer.json

Oliver Klee CR +2 V +2 Normal +7 −109 updated 06/29/20, 16:50

Commit message

Some system extensions use functions like libxml_disable_entity_loader
which are provided by ext-libxml. To make sure these methods are
available, this PHP extension needs to be required.

Used composer command:

  composer require ext-libxml:"*"

Also add the extension as required in the install tool.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 5365

Show 3540 earlier messages
  1. Oliver Klee uploaded patch set 1 04/16/20, 16:19

  2. TYPO3com voted on patch set 1 V +1 04/16/20, 16:30 Completed build in 11m 46s on Thu, 16 Apr, 04:30 PM Test Summary: 73561 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2656

  3. Anja Leichsenring voted on patch set 1 V +1 CR +1 04/16/20, 16:47

  4. Oli Bartsch voted on patch set 1 V +1 CR +1 04/16/20, 17:37

  5. Alexander Schnitzler commented on patch set 1 04/16/20, 19:04

    composer.json:25

    Isn't this also missing in our main composer.json?
  6. Oliver Klee commented on patch set 1 04/16/20, 19:19

    composer.json:25 Reply

    Do we generally need to have the dependencies in the core extensions duplicated in the main composer.json? If so, I can add it.
  7. Andreas Kienast commented on patch set 1 04/16/20, 19:26

    composer.json:25 Reply

    Yes and technically in any other affected core extension as well. libxml_disable_entity_loader e.g. is also used in EXT:extensionmanager, EXT:frontend, EXT:t3editor and EXT:recycler (the latter in tests only).
  8. Oliver Klee commented on patch set 1 CR -1 04/16/20, 20:05

    Thanks for the insights. I'll update the changeset in a minute.
  9. Oliver Klee uploaded patch set 2 04/16/20, 20:31

  10. TYPO3com voted on patch set 2 V +1 04/16/20, 20:43 Completed build in 11m 16s on Thu, 16 Apr, 08:43 PM Test Summary: 73561 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2663

  11. Josef Glatz commented on patch set 2 V +1 CR +1 04/17/20, 05:57

    composer.lock:8154

    this is new to me? is this because of a new composer version which adds this information now? (like the fundings)
  12. Oliver Klee commented on patch set 2 04/17/20, 07:49

    composer.lock:8154 Reply

    Yes, this comes with the new Composer version (in my case 1.10.5).
  13. Josef Glatz commented on patch set 2 04/17/20, 07:52

    composer.lock:8154 Reply

    Done
  14. Alexander Schnitzler commented on patch set 2 04/17/20, 07:57

    composer.json:25 Reply

    How did you find out which extensions need this extension? Manual check or did you use a tool?
  15. Andreas Kienast commented on patch set 2 04/17/20, 08:17

    composer.json:25 Reply

    Manual check for that function
  16. Oliver Klee commented on patch set 2 04/17/20, 08:35

    composer.json:25 Reply

    I also searched for "libxml_".
  17. Oliver Klee commented on patch set 2 04/17/20, 08:35

    composer.json:25 Reply Unresolved

    (manually in my IDE)
  18. Christian Eßl voted on patch set 2 V +1 CR +1 04/17/20, 11:41

  19. Oli Bartsch voted on patch set 2 V +1 CR +1 04/17/20, 12:40

  20. Guido Schmechel voted on patch set 2 CR +1 04/17/20, 15:16

  21. Oliver Klee uploaded patch set 3 04/20/20, 09:21

  22. Oliver Klee commented on patch set 3 04/20/20, 09:21

    rebased
  23. Oliver Klee uploaded patch set 4 04/20/20, 09:22

  24. TYPO3com voted on patch set 3 V -1 04/20/20, 09:23 Completed build in 23s on Mon, 20 Apr, 09:23 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2877

  25. TYPO3com voted on patch set 4 V +1 04/20/20, 09:42 Completed build in 19m 31s on Mon, 20 Apr, 09:42 AM Test Summary: 73627 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2879

  26. Josef Glatz commented on patch set 4 CR -1 04/20/20, 10:21

    composer.json:24

    Any valid reason why ext:recycler uses require-dev section for ext-libxml?
  27. Oliver Klee commented on patch set 4 04/20/20, 10:23

    composer.json:24 Reply

    Yes, there the corresponding function is used in the tests only.
  28. Josef Glatz commented on patch set 4 V +1 CR +1 04/20/20, 10:33

    composer.json:24 Reply

    Done
  29. Georg Ringer voted on patch set 4 V +1 CR +1 04/20/20, 11:59

  30. Oli Bartsch voted on patch set 4 V +1 CR +1 04/20/20, 13:00

  31. Wouter Wolters voted on patch set 4 CR +1 04/20/20, 18:30

  32. Tymoteusz Motylewski commented on patch set 4 CR -1 04/20/20, 19:08

    I believe the new extension should also be added to typo3/sysext/install/Classes/SystemEnvironment/Check.php at last for $suggestedPhpExtensions
  33. Josef Glatz commented on patch set 4 04/21/20, 11:06

    > Patch Set 4: Code-Review-1 > > I believe the new extension should also be added to typo3/sysext/install/Classes/SystemEnvironment/Check.php > at last for $suggestedPhpExtensions Technically it’s only a check and not a somehow direct dependency on libxml. can't make up my mind 100%.
  34. Oliver Klee uploaded patch set 5 04/21/20, 11:10

  35. Oliver Klee commented on patch set 5 04/21/20, 11:11

    > I believe the new extension should also be added to typo3/sysext/install/Classes/SystemEnvironment/Check.php > at last for $suggestedPhpExtensions I've just added it as required.
  36. TYPO3com voted on patch set 5 V +1 04/21/20, 11:23 Completed build in 12m 34s on Tue, 21 Apr, 11:23 AM Test Summary: 73657 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2946

  37. Josef Glatz commented on patch set 5 CR +1 04/21/20, 11:26

    > Patch Set 4: Code-Review-1 > > I believe the new extension should also be added to typo3/sysext/install/Classes/SystemEnvironment/Check.php > at last for $suggestedPhpExtensions I'm not really sure if
  38. Guido Schmechel voted on patch set 5 CR +1 05/02/20, 10:20

  39. Benni Mack voted on patch set 5 V +1 CR +1 05/02/20, 11:54

  40. Benni Mack commented on patch set 5 05/02/20, 14:29

    Can you also added the used composer command to the commit message?
  1. Oliver Klee commented on patch set 5 05/02/20, 16:42

    > Can you also added the used composer command to the commit message? Will do (and I'll also rebase).
  2. Anja Leichsenring uploaded patch set 6 05/25/20, 17:04

  3. TYPO3com voted on patch set 6 V +1 05/25/20, 17:16 Completed build in 11m 16s on Mon, 25 May, 05:16 PM Test Summary: 73808 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3518

  4. Anja Leichsenring commented on patch set 6 V +1 CR +1 05/25/20, 17:18

    > Patch Set 5: > > > Can you also added the used composer command to the commit message? > > Will do (and I'll also rebase).
  5. Benni Mack updated the commit message in patch set 7 05/25/20, 18:54

  6. Oliver Klee commented on patch set 7 05/25/20, 21:39

    Thanks, Anja and Benni!
  7. Anja Leichsenring uploaded patch set 8 05/26/20, 16:10

  8. TYPO3com voted on patch set 8 V +1 05/26/20, 17:32 Completed build in 1h 20m 11s on Tue, 26 May, 05:32 PM Test Summary: 73808 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3571

  9. Anja Leichsenring uploaded patch set 9 05/31/20, 12:14

  10. Anja Leichsenring voted on patch set 9 V +1 CR +1 05/31/20, 12:14

  11. TYPO3com voted on patch set 9 V +1 05/31/20, 12:25 Completed build in 11m 45s on Sun, 31 May, 12:25 PM Test Summary: 72899 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3719

  12. Benjamin Franzke commented on patch set 9 CR -1 05/31/20, 19:11

    composer.lock:4168

    The removal of ocramius/package-versions and the addition of composer/package-versions-deprecated via composer.lock looks like an additional `composer update` has been performed. That's something for another change and shouldn't be part of this commit. The composer.lock should be cleanly regenerated using: git checkout HEAD^ -- composer.json composer.lock composer require ext-libxml:"*"
  13. Benjamin Franzke uploaded patch set 10 1 comment 05/31/20, 19:46

  14. TYPO3com voted on patch set 10 V +1 05/31/20, 19:57 Completed build in 11m 26s on Sun, 31 May, 07:57 PM Test Summary: 72842 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3722

  15. Daniel Haupt voted on patch set 10 V +1 06/01/20, 17:20

  16. Daniel Haupt voted on patch set 10 CR +1 06/01/20, 17:21

  17. Anja Leichsenring uploaded patch set 11 06/28/20, 07:32

  18. Anja Leichsenring uploaded patch set 12 06/28/20, 07:35

  19. Anja Leichsenring uploaded patch set 13 06/28/20, 07:36

  20. Anja Leichsenring voted on patch set 13 V +1 CR +1 06/28/20, 07:37

  21. TYPO3com voted on patch set 11 V +1 06/28/20, 07:45 Completed build in 12m 56s on Sun, 28 Jun, 07:45 AM Test Summary: 72863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3997

  22. TYPO3com voted on patch set 12 V +1 06/28/20, 07:50 Completed build in 14m 46s on Sun, 28 Jun, 07:50 AM Test Summary: 72863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3998

  23. TYPO3com voted on patch set 13 V +1 06/28/20, 07:54 Completed build in 13m 00s on Sun, 28 Jun, 07:54 AM Test Summary: 72862 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3999

  24. Daniel Goerz voted on patch set 13 V +2 CR +2 06/29/20, 16:50

  25. Daniel Goerz merged patch set 14 06/29/20, 16:50