Review main Merged

64205[BUGFIX] Boot container for E-Mail check in install tool

Benjamin Franzke CR +2 V +2 Easy +23 −0 updated 04/16/20, 20:50

Commit message

Since #90266 install tool E-Mails are templated and
custom logos, viewhelpers or services may be loaded.

A custom backend login logo caused the usage of the f:image
ViewHelper which triggered the FileIndexRepository which
wasn't configured for the install tool context.

Therefore we need to provide a fully booted
symfony container in order for dependency injection
to work for all core and third party extensions,
especially when using a customized SystemEmail template.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Georg Ringer +1
    • Martin Hotmann +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Georg Ringer +1
    • Martin Hotmann +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 79

  1. Benjamin Franzke uploaded patch set 1 04/16/20, 16:35

  2. TYPO3com voted on patch set 1 V +1 04/16/20, 16:47 Completed build in 11m 24s on Thu, 16 Apr, 04:46 PM Test Summary: 73561 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2657

  3. Benjamin Franzke updated the commit message in patch set 2 04/16/20, 16:57

  4. Benjamin Franzke wrote 04/16/20, 16:57

    Topic set to di
  5. TYPO3com voted on patch set 2 V +1 04/16/20, 17:08 Completed build in 11m 13s on Thu, 16 Apr, 05:08 PM Test Summary: 73561 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2658

  6. Martin Hotmann commented on patch set 2 V +1 CR +1 04/16/20, 17:15

    Solved the sending Mail bug for me when TYPO3 Login Logo is specified
  7. Georg Ringer voted on patch set 2 V +1 CR +1 04/16/20, 20:07

  8. Benjamin Franzke voted on patch set 2 V +2 CR +2 04/16/20, 20:50

  9. Benjamin Franzke merged patch set 3 04/16/20, 20:50