Review main Merged

64207[BUGFIX] Disable trigger buttons in Install Tool when actions are executed

Andreas Kienast CR +2 V +2 Hard +233 −208 updated 05/21/20, 13:02

Commit message

If an action in the Install Tool is executed that is related to an
inline module or an interactable module (a.k.a "modal"), its trigger
button(s) get now properly disabled and enabled to avoid executing the
same actions consecutively while any request is still pending.

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Susi Moog +2
    • Jonas Eberle +1
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 45

Show 25 more files

Review log 3345

Show 1420 earlier messages
  1. Andreas Kienast uploaded patch set 1 04/17/20, 06:59

  2. Markus Klein commented on patch set 1 04/17/20, 07:11

    " missing

    AbstractInteractableModule.ts:37

    can we do: this.getModalFooter().find('button').each((this: HTMLElement) => this.setModalButtonState($(this), interactable)); I'd rather keep the toggle and prop-stuff in a single central place
  3. TYPO3com voted on patch set 1 V +1 04/17/20, 07:11 Completed build in 12m 39s on Fri, 17 Apr, 07:11 AM Test Summary: 73561 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2688

  4. Markus Klein commented on patch set 1 04/17/20, 07:14

    CreateAdmin.ts:79

    Where is this enabled?
  5. Andreas Kienast commented on patch set 1 V -1 04/17/20, 08:00

    Reply

    Ack

    AbstractInteractableModule.ts:37 Reply

    Ack

    CreateAdmin.ts:79 Reply Unresolved

    Good catch
  6. Andreas Kienast uploaded patch set 2 04/17/20, 08:06

  7. Andreas Kienast updated the commit message in patch set 3 04/17/20, 08:06

  8. Oliver Klee commented on patch set 3 04/17/20, 08:10

    Should that be "if" or "when" (i.e., is it about the action happening or not happening), or is it about the timing?
  9. Andreas Kienast commented on patch set 3 04/17/20, 08:26

    Reply

    The buttons are disabled from start to end of the executed action
  10. TYPO3com voted on patch set 2 V -1 04/17/20, 08:26 Completed build in 15m 25s on Fri, 17 Apr, 08:26 AM Test Summary: 73561 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2695

  11. TYPO3com voted on patch set 3 V -1 04/17/20, 08:30 Completed build in 19m 35s on Fri, 17 Apr, 08:30 AM Test Summary: 73561 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2696

  12. Oliver Klee commented on patch set 3 04/17/20, 08:37

    Reply Unresolved

    Then this indeed needs to be a "when", not an "if" (both in the commit message subject as well as the description). Should I change it, or would you like to change it (e.g., if the changeset needs other changes as well)?
  13. Andreas Kienast uploaded patch set 4 04/17/20, 09:39

  14. Andreas Kienast uploaded patch set 5 04/17/20, 10:17

  15. TYPO3com voted on patch set 4 V -1 04/17/20, 10:24 Completed build in 20m 02s on Fri, 17 Apr, 10:24 AM Test Summary: 3 of 74046 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2706

  16. TYPO3com voted on patch set 5 V +1 04/17/20, 10:37 Completed build in 14m 34s on Fri, 17 Apr, 10:37 AM Test Summary: 73561 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2709

  17. Markus Klein commented on patch set 5 CR -1 04/17/20, 19:22

    AbstractInteractableModule.ts:40 Unresolved

    hm... that line should not be here anymore ,right?
  18. Andreas Kienast uploaded patch set 6 04/17/20, 19:32

  19. TYPO3com voted on patch set 6 V +1 04/17/20, 19:48 Completed build in 15m 46s on Fri, 17 Apr, 07:48 PM Test Summary: 73609 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2750

  20. Markus Klein voted on patch set 6 V +1 CR +1 04/17/20, 22:12

  1. Jonas Eberle voted on patch set 6 V +1 04/18/20, 14:00

  2. Frank Nägler commented on patch set 6 V -1 04/20/20, 14:20

    System Maintainer Modal broken, Andy will have a look
  3. Andreas Kienast uploaded patch set 7 04/20/20, 14:34

  4. Frank Nägler voted on patch set 7 V +1 CR +1 04/20/20, 14:52

  5. TYPO3com voted on patch set 7 V -1 04/20/20, 14:52 Completed build in 17m 12s on Mon, 20 Apr, 02:52 PM Test Summary: 73657 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2902

  6. TYPO3com commented on patch set 7 04/20/20, 15:09 Completed build in 51m 22s on Mon, 20 Apr, 03:09 PM Test Summary: 73657 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2902

  7. Andreas Kienast uploaded patch set 8 04/20/20, 15:39

  8. TYPO3com voted on patch set 8 V +1 04/20/20, 15:57 Completed build in 13m 40s on Mon, 20 Apr, 03:57 PM Test Summary: 73657 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2912

  9. Markus Klein voted on patch set 8 V +1 CR +1 04/20/20, 21:10

  10. Jonas Eberle voted on patch set 8 V +1 04/26/20, 10:21

  11. Oliver Hader voted on patch set 8 CR -1 04/26/20, 10:49

  12. Oliver Hader commented on patch set 8 04/26/20, 10:49

  13. Oliver Hader commented on patch set 8 04/26/20, 10:50

  14. Andreas Kienast commented on patch set 8 04/26/20, 11:02

    tsconfig.json:101 Reply Unresolved

    I don't know why this line pops up, Bamboo already complained when I removed it again.
  15. Andreas Kienast commented on patch set 8 CR -1 04/26/20, 11:03

    SetupModule.js:16 Reply Unresolved

    Args. I didn't spot that, will update the patch ASAP.
  16. Andreas Kienast uploaded patch set 9 04/26/20, 11:09

  17. Andreas Kienast uploaded patch set 10 04/26/20, 11:11

  18. TYPO3com voted on patch set 9 V +1 04/26/20, 11:21 Completed build in 11m 56s on Sun, 26 Apr, 11:21 AM Test Summary: 73657 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3030

  19. TYPO3com voted on patch set 10 V -1 04/26/20, 11:29 Completed build in 17m 53s on Sun, 26 Apr, 11:29 AM Test Summary: 73657 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3031

  20. TYPO3com voted on patch set 10 V +1 04/26/20, 12:07 Completed build in 1h 13m 16s on Sun, 26 Apr, 12:07 PM Test Summary: 73657 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3031

  21. Jonas Eberle voted on patch set 10 V +1 04/26/20, 12:24

  22. Susi Moog voted on patch set 10 CR +1 05/21/20, 12:58

  23. Anja Leichsenring voted on patch set 10 V +1 CR +1 05/21/20, 13:01

  24. Susi Moog voted on patch set 10 V +2 CR +2 05/21/20, 13:02

  25. Susi Moog merged patch set 11 05/21/20, 13:02