Review main Merged

64209[TASK] Pass targetElement explicitly for RegularEvent.delegateTo

Oliver Hader CR +2 V +2 Easy +7 −3 updated 04/17/20, 11:16

Commit message

Arrow functions keep using their own `thisArg` on invocation. To
be able to avoid unscoped `function()` call and still retrieving
`targetElement` it is passed explicitly as 2nd callback argument.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 912

  1. Oliver Hader uploaded patch set 1 04/17/20, 10:25

  2. TYPO3com voted on patch set 1 V +1 04/17/20, 10:42 Completed build in 14m 44s on Fri, 17 Apr, 10:42 AM Test Summary: 73561 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2710

  3. Andreas Kienast uploaded patch set 2 04/17/20, 10:54

  4. Andreas Kienast voted on patch set 2 V +1 CR +1 04/17/20, 10:55

  5. Andreas Kienast commented on patch set 2 V 0 CR -1 04/17/20, 10:57

    on it
  6. Andreas Kienast uploaded patch set 3 04/17/20, 10:58

  7. Andreas Kienast voted on patch set 3 V +1 CR +1 04/17/20, 10:58

  8. Oliver Hader voted on patch set 3 CR +1 04/17/20, 10:58

  9. TYPO3com voted on patch set 2 V +1 04/17/20, 11:06 Completed build in 11m 55s on Fri, 17 Apr, 11:06 AM Test Summary: 73559 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2711

  10. TYPO3com voted on patch set 3 V +1 04/17/20, 11:12 Completed build in 14m 11s on Fri, 17 Apr, 11:12 AM Test Summary: 73561 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2712

  11. Oliver Hader voted on patch set 3 V +2 CR +2 04/17/20, 11:16

  12. Oliver Hader merged patch set 4 04/17/20, 11:16