Review main Merged

64214[BUGFIX] Reset click events in buttons of MultiStepWizard

Andreas Kienast CR +2 V +2 Easy +25 −13 updated 04/19/20, 09:23

Commit message

When the MultiStepWizard is used with additional click events bound to
the next or prev button, those event got stacked as the buttons don't
change per step.

To fix this issue, all click events are removed after switching a step
and the original click event to switch the step is bound again.

Furthermore the 'savePath' for duplication of a form is now correctly
set if there is only one folder available and therefore no select element
present in the modal.

Review

  • Code review CR +2 Done
    • Christian Eßl +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Christian Eßl +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1320

  1. Andreas Kienast uploaded patch set 1 04/17/20, 14:46

  2. Christian Eßl commented on patch set 1 V -1 04/17/20, 14:51

    With this, changing the Form storage in step 2 of the wizard will do nothing. Copying a form to another form storage is no longer possible.
  3. TYPO3com voted on patch set 1 V +1 04/17/20, 14:59 Completed build in 12m 06s on Fri, 17 Apr, 02:59 PM Test Summary: 73567 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2736

  4. Andreas Kienast commented on patch set 1 V -1 CR -2 04/17/20, 15:00

    The root cause is somewhere different.
  5. Andreas Kienast uploaded patch set 2 04/17/20, 15:35

  6. Andreas Kienast voted on patch set 2 CR 0 04/17/20, 15:35

  7. Christian Eßl commented on patch set 2 V +1 CR +1 04/17/20, 15:39

    Looks good. Tested with the wizard for copying forms and the wizard for creating new forms.
  8. TYPO3com voted on patch set 2 V +1 04/17/20, 15:47 Completed build in 12m 16s on Fri, 17 Apr, 03:47 PM Test Summary: 73567 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2744

  9. Oli Bartsch commented on patch set 2 V -1 04/18/20, 11:51

    On it
  10. Oli Bartsch uploaded patch set 3 04/18/20, 12:02

  11. Oli Bartsch updated the commit message in patch set 4 04/18/20, 12:03

  12. Oli Bartsch voted on patch set 4 V +1 CR +1 04/18/20, 12:04

  13. Christian Eßl voted on patch set 4 V +1 CR +1 04/18/20, 12:14

  14. TYPO3com voted on patch set 3 V +1 04/18/20, 12:38 Completed build in 20m 38s on Sat, 18 Apr, 12:38 PM Test Summary: 73627 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2786

  15. TYPO3com voted on patch set 4 V -1 04/18/20, 12:44 Completed build in 26m 36s on Sat, 18 Apr, 12:44 PM Test Summary: 1 of 74111 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2787

  16. TYPO3com commented on patch set 4 04/18/20, 13:29 Completed build in 25m 19s on Sat, 18 Apr, 01:29 PM Test Summary: 73627 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2796

  17. TYPO3com commented on patch set 4 04/18/20, 13:36 Completed build in 04m 05s on Sat, 18 Apr, 01:36 PM Test Summary: 6 of 52902 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2800

  18. TYPO3com voted on patch set 4 V +1 04/18/20, 14:58 Completed build in 12m 44s on Sat, 18 Apr, 02:58 PM Test Summary: 73627 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2810

  19. Christian Eßl voted on patch set 4 V +2 CR +2 04/19/20, 09:23

  20. Christian Eßl merged patch set 5 04/19/20, 09:23