Review main Merged

64215[BUGFIX] Resolve non-hidden workspace version of hidden live page properly

Benni Mack CR +2 V +2 Easy +8 −7 updated 04/22/20, 09:58

Commit message

When a live page is hidden, but the workspace version is not hidden,
the actual content is now shown properly.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Hader +1
    • Susi Moog +1
  • Verified V +2 Done
    • Benni Mack +2
    • Riccardo De Contardi +1
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1318

  1. Benni Mack uploaded patch set 1 04/17/20, 15:02

  2. Benni Mack updated the commit message in patch set 2 04/17/20, 15:03

  3. TYPO3com voted on patch set 1 V +1 04/17/20, 15:15 Completed build in 13m 03s on Fri, 17 Apr, 03:15 PM Test Summary: 73567 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2738

  4. TYPO3com voted on patch set 2 V +1 04/17/20, 15:21 Completed build in 16m 55s on Fri, 17 Apr, 03:21 PM Test Summary: 73567 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2739

  5. Benni Mack uploaded patch set 3 04/17/20, 15:22

  6. TYPO3com voted on patch set 3 V +1 04/17/20, 15:35 Completed build in 13m 17s on Fri, 17 Apr, 03:35 PM Test Summary: 73567 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2742

  7. Riccardo De Contardi commented on patch set 3 04/17/20, 16:12

    My test so far (if I am not wrong) https://forge.typo3.org/issues/82462 seems already solved patch solves https://forge.typo3.org/issues/85003 patch does not solve https://forge.typo3.org/issues/88054
  8. Susi Moog updated the commit message in patch set 4 04/19/20, 06:07

  9. Susi Moog voted on patch set 4 V +1 CR +1 04/19/20, 06:07

  10. TYPO3com voted on patch set 4 V +1 04/19/20, 06:19 Completed build in 12m 17s on Sun, 19 Apr, 06:19 AM Test Summary: 73627 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2828

  11. Riccardo De Contardi commented on patch set 4 V +1 04/19/20, 08:40

    Only commit message changes; I give my +1 because it solves #85003 About #82462 - the test on comment 16 seems unaffected by this patch (issue does not occur with or without the patch) - the test on comment 18 is still negative (issue still occurs)
  12. Benni Mack updated the commit message in patch set 5 04/19/20, 19:19

  13. TYPO3com voted on patch set 5 V +1 04/19/20, 19:30 Completed build in 10m 54s on Sun, 19 Apr, 07:30 PM Test Summary: 73626 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2856

  14. Riccardo De Contardi commented on patch set 5 V +1 04/19/20, 19:51

    Tested with latest master, solves #85003
  15. Susi Moog voted on patch set 5 V +1 CR +1 04/20/20, 04:26

  16. Oliver Hader voted on patch set 5 CR +1 04/22/20, 09:00

  17. Benni Mack voted on patch set 5 V +2 CR +2 04/22/20, 09:58

  18. Benni Mack merged patch set 6 04/22/20, 09:58