Review main Abandoned Breaking

64217[WIP][!!!][TASK] Replace method injection with constructor injection

Alexander Schnitzler CR 0 V 0 Hard +64 −466 updated 12/09/21, 12:09

Commit message

This is an example patch showing the work of a rector.
No manual changes, rector only.

Review

  • Code review CR 0
  • Verified V 0

Files 32

Show 12 more files

Review log 56

  1. Alexander Schnitzler uploaded patch set 1 04/17/20, 17:14

  2. TYPO3com voted on patch set 1 V -1 04/17/20, 17:20 Completed build in 05m 55s on Fri, 17 Apr, 05:20 PM Test Summary: 6169 of 66809 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2746

  3. Alexander Schnitzler commented on patch set 1 04/17/20, 17:33

  4. Benni Mack wrote 11/29/21, 09:58

    Change destination moved from master to main
  5. Benni Mack updated the commit message in patch set 2 11/29/21, 13:17

  6. Christian Kuhn abandoned the change 12/09/21, 12:09

    Hey. I hope it's ok to abandon this for now: We meanwhile changed various classes regarding injection in v11. The patch is pretty large and also has some hard -1 reasons: For instance ActionController: This is an abstract class, extensions *should* extend from this. Extensions then should be able to use constructor injection. If ActionController would do the same, extension classes would need to call parent::__construct(), handing over all inject suitable for ActionController. This is unfortunate. It's much better to keep inject* methods for 'abstract' classes and to simply not use __construct, so extending class and base class don't have a dependency on each other regarding injection. Let's continue to adapt injection at places where it's useful when we need it, and let's abandon this patch for now.