64217[WIP][!!!][TASK] Replace method injection with constructor injection
Commit message
Review
-
Code review CR 0
-
Verified V 0
Files 32
- typo3/sysext/extbase/Classes/Mvc/Controller/AbstractController.php+3 −32
- typo3/sysext/extbase/Classes/Mvc/Controller/ActionController.php+5 −74
- typo3/sysext/extbase/Classes/Mvc/Controller/Argument.php+3 −17
- typo3/sysext/extbase/Classes/Mvc/Controller/Arguments.php+2 −9
- typo3/sysext/extbase/Classes/Mvc/Controller/ControllerContext.php+1 −12
- typo3/sysext/extbase/Classes/Mvc/Controller/MvcPropertyMappingConfigurationService.php+1 −4
- typo3/sysext/extbase/Classes/Mvc/View/JsonView.php+1 −14
- typo3/sysext/extbase/Classes/Mvc/Web/Routing/UriBuilder.php+1 −22
- typo3/sysext/extbase/Classes/Mvc/Web/AbstractRequestHandler.php+1 −26
- typo3/sysext/extbase/Classes/Mvc/Web/FrontendRequestHandler.php+2 −4
- typo3/sysext/extbase/Classes/Mvc/Web/RequestBuilder.php+1 −26
- typo3/sysext/extbase/Classes/Mvc/Web/Response.php+1 −6
- typo3/sysext/extbase/Classes/Mvc/RequestHandlerResolver.php+2 −9
- typo3/sysext/extbase/Classes/Persistence/Generic/Qom/QueryObjectModelFactory.php+1 −4
- typo3/sysext/extbase/Classes/Persistence/Generic/Storage/Typo3DbBackend.php+5 −33
- typo3/sysext/extbase/Classes/Persistence/Generic/Storage/Typo3DbQueryParser.php+3 −20
- typo3/sysext/extbase/Classes/Persistence/Generic/LazyLoadingProxy.php+2 −9
- typo3/sysext/extbase/Classes/Persistence/Generic/LazyObjectStorage.php+2 −9
- typo3/sysext/extbase/Classes/Persistence/Generic/Query.php+5 −33
- typo3/sysext/extbase/Classes/Persistence/Generic/QueryResult.php+3 −17
Show 12 more files
- typo3/sysext/extbase/Classes/Persistence/Generic/Typo3QuerySettings.php+1 −4
- typo3/sysext/extbase/Classes/Persistence/Repository.php+2 −9
- typo3/sysext/extbase/Classes/Property/TypeConverter/AbstractFileCollectionConverter.php+2 −4
- typo3/sysext/extbase/Classes/Property/TypeConverter/AbstractFileFolderConverter.php+2 −4
- typo3/sysext/extbase/Classes/Property/TypeConverter/AbstractTypeConverter.php+1 −5
- typo3/sysext/extbase/Classes/Property/TypeConverter/ObjectConverter.php+2 −12
- typo3/sysext/extbase/Classes/Property/TypeConverter/PersistentObjectConverter.php+2 −5
- typo3/sysext/extbase/Classes/Property/PropertyMapper.php+1 −14
- typo3/sysext/extbase/Classes/Service/CacheService.php+2 −9
- typo3/sysext/extbase/Classes/Service/ExtensionService.php+1 −4
- typo3/sysext/extbase/Classes/Validation/Validator/CollectionValidator.php+2 −4
- typo3/sysext/extbase/Classes/Validation/ValidatorResolver.php+1 −12
Review log 56
-
Alexander Schnitzler uploaded patch set 1 04/17/20, 17:14
-
TYPO3com voted on patch set 1 V -1 04/17/20, 17:20 Completed build in 05m 55s on Fri, 17 Apr, 05:20 PM Test Summary: 6169 of 66809 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2746
-
Alexander Schnitzler commented on patch set 1 04/17/20, 17:33
Rector used for this change: https://gist.github.com/alexanderschnitzler/f664b458f2bc47833c7a55f93b5a363d -
Benni Mack wrote 11/29/21, 09:58
Change destination moved from master to main -
Benni Mack updated the commit message in patch set 2 11/29/21, 13:17
-
Christian Kuhn abandoned the change 12/09/21, 12:09
Hey. I hope it's ok to abandon this for now: We meanwhile changed various classes regarding injection in v11. The patch is pretty large and also has some hard -1 reasons: For instance ActionController: This is an abstract class, extensions *should* extend from this. Extensions then should be able to use constructor injection. If ActionController would do the same, extension classes would need to call parent::__construct(), handing over all inject suitable for ActionController. This is unfortunate. It's much better to keep inject* methods for 'abstract' classes and to simply not use __construct, so extending class and base class don't have a dependency on each other regarding injection. Let's continue to adapt injection at places where it's useful when we need it, and let's abandon this patch for now.