Review main Merged

64219[BUGFIX] Use correct identifier for "england" flag icon

Andreas Kienast CR +2 V +2 Easy +20 −1 updated 04/22/20, 08:52

Commit message

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Markus Klein +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 2632

Show 57 earlier messages
  1. Andreas Kienast uploaded patch set 1 04/17/20, 19:29

  2. TYPO3com voted on patch set 1 V -1 04/17/20, 19:42 Completed build in 13m 05s on Fri, 17 Apr, 07:42 PM Test Summary: 73270 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2749

  3. TYPO3com voted on patch set 1 V +1 04/17/20, 19:50 Completed build in 34m 20s on Fri, 17 Apr, 07:50 PM Test Summary: 73609 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2749

  4. Björn Jacob voted on patch set 1 CR +1 04/17/20, 19:57

  5. Simon Gilli voted on patch set 1 V +1 04/17/20, 20:00

  6. Simon Gilli wrote 04/17/20, 20:00

    Removed Verified+1 by Simon Gilli <typo3@gilbertsoft.org>
  7. Simon Gilli voted on patch set 1 CR +1 04/17/20, 20:00

  1. Markus Klein voted on patch set 1 V +1 CR +1 04/17/20, 20:52

  2. Richard Haeser commented on patch set 1 04/17/20, 21:01

    What about when people already have selected this flag? The option england will not be available anymore so you will get an invalid option in the select now. I know this is broken now, but for sure people need to change their flag to get the right one. Was this taken in consideration?
  3. Markus Klein commented on patch set 1 04/17/20, 21:07

    > Patch Set 1: > > What about when people already have selected this flag? The option england will not be available anymore so you will get an invalid option in the select now. I know this is broken now, but for sure people need to change their flag to get the right one. Was this taken in consideration? Yes, but at least people are informed now that this value is invalid and they have to adjust. The functionality of the Core is not worse than it already is.
  4. Riccardo De Contardi commented on patch set 1 V +1 04/17/20, 21:11

    It works (tested on latest master) but Richard Haeser is right: the language flag needs to be reselected in the Site module. I think that at least a little documentation is necessary, maybe on the release notes of the next version. (Don't know on 9.5)
  5. Richard Haeser commented on patch set 1 CR -1 04/17/20, 21:14

    > Patch Set 1: Verified+1 > > It works (tested on latest master) but Richard Haeser is right: the language flag needs to be reselected in the Site module. I think that at least a little documentation is necessary, maybe on the release notes of the next version. (Don't know on 9.5) You can also use it in frontend so this might be breaking. Will discuss if we want to push this one.
  6. Richard Haeser commented on patch set 1 04/17/20, 21:22

    Discussed with Benni. We need to change this a little bit. For v10 we can do this change but with an Important RST. For v9 we should keep both options.
  7. Richard Haeser uploaded patch set 2 04/17/20, 21:28

  8. Richard Haeser voted on patch set 2 V +1 CR +1 04/17/20, 21:29

  9. Markus Klein commented on patch set 2 04/17/20, 21:33

    Important-91099-ChangedFlagIdentifierForEngland.rst:12 Unresolved

    was broken documentation (in contrast to commit messages) is not in present tense
  10. Markus Klein commented on patch set 2 CR -1 04/17/20, 21:33

    will fix it
  11. Markus Klein commented on patch set 3 04/17/20, 21:37

    Published edit on patch set 2.
  12. Markus Klein commented on patch set 4 04/17/20, 21:38

    Published edit on patch set 3.
  13. Richard Haeser voted on patch set 4 V +1 CR +1 04/17/20, 21:38

  14. Markus Klein commented on patch set 5 04/17/20, 21:38

    Published edit on patch set 4.
  15. Richard Haeser voted on patch set 5 V +1 CR +1 04/17/20, 21:40

  16. Markus Klein voted on patch set 5 V +1 CR +1 04/17/20, 21:40

  17. TYPO3com voted on patch set 2 V +1 04/17/20, 21:41 Completed build in 12m 14s on Fri, 17 Apr, 09:41 PM Test Summary: 73609 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2756

  18. TYPO3com voted on patch set 3 V +1 04/17/20, 21:50 Completed build in 13m 10s on Fri, 17 Apr, 09:50 PM Test Summary: 73609 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2757

  19. TYPO3com voted on patch set 4 V +1 04/17/20, 21:55 Completed build in 15m 54s on Fri, 17 Apr, 09:55 PM Test Summary: 73609 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2758

  20. TYPO3com voted on patch set 5 V +1 04/17/20, 21:59 Completed build in 19m 49s on Fri, 17 Apr, 09:59 PM Test Summary: 73609 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2759

  21. Richard Haeser voted on patch set 5 V +2 CR +2 04/17/20, 21:59

  22. Richard Haeser merged patch set 6 04/17/20, 21:59

  23. Benni Mack commented on patch set 6 04/22/20, 06:53

    Btw... who came up with "gb-eng" and can you explain to me what this should mean? I've been reworking Locales and this part since TYPO3 v7 and wonder what kind of format / standard this is.
  24. Andreas Kienast commented on patch set 6 04/22/20, 07:36

    > Patch Set 6: > > Btw... who came up with "gb-eng" and can you explain to me what this should mean? I've been reworking Locales and this part since TYPO3 v7 and wonder what kind of format / standard this is. Any value of that huge select (like "gb-eng") is used as identifier for all flags used in the whole backend and probably was there since we started working with flags.
  25. Benni Mack commented on patch set 6 04/22/20, 08:52

    All fine, also rechecked - it's ISO 3166-2