Review main Abandoned

64227[FEATURE] Convert extensionKey to extensionName if necessary

Thomas Pronold CR 0 V 0 Easy +6 −0 updated 11/05/21, 08:20

Commit message

As for now, the translate() function accepts lowercase extension
keys without underscores. Either lowercase extension keys should
really be prohibited or silently accepted and converted to the
extension name in UpperCamelCase. The latter is provided by this
patch.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 1417

  1. Thomas Pronold uploaded patch set 1 04/18/20, 11:38

  2. Oliver Klee commented on patch set 1 04/18/20, 11:53

    Can we cover this with a test?
  3. Oli Bartsch commented on patch set 1 V -1 04/18/20, 12:16

    Hi, thanks for your contribution! Could you please add proper line breaks to your commit message. See https://docs.typo3.org/m/typo3/guide-contributionworkflow/master/en-us/Appendix/CommitMessage.html?#commit-message-rules-for-typo3-cms for more information regarding this topic. Furthermore since this is a feature it can't be backported to older branches and also needs a RST describing the new feature see: https://docs.typo3.org/m/typo3/guide-contributionworkflow/master/en-us/AddingDocumentation/Index.html#features
  4. TYPO3com voted on patch set 1 V -1 04/18/20, 12:21 Completed build in 31m 27s on Sat, 18 Apr, 12:21 PM Test Summary: 120 of 74111 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2783

  5. Alexander Schnitzler wrote 04/18/20, 12:38

    Topic set to extbase
  6. Alexander Schnitzler commented on patch set 1 04/18/20, 12:41

    If this is a feature, it cannot be merged into 9.5 and master now due to feature freeze and backport freeze. Let's postpone this 2 weeks until development of version 11 started. Besides that I have ideas already for this topic as we have a couple of formats we pass along our methods and I would like to replace that with an object.
  7. Thomas Pronold commented on patch set 1 04/18/20, 13:00

    Thanks for reviewing. I will write tests etc. if it is decided how this is handled in the future. I put a little bit more thought into this thing, and I think the function should not accept lowercase extension keys at all. This would probably affect a couple of thousand core lines where this is happening. The underlying problem with this is, that in the ConfigurationManager, AbstractConfigurationManager classes, etc. is a lot of strtowlower() stuff going on, which works when "Core" becomes "core" but does not work with MyExt and my_ext, the result is ofc different. myext and my_ext... Even the current tests are written with "core" as a parameter and do fail when using "Core".
  8. Thomas Pronold uploaded patch set 2 04/18/20, 13:45

  9. TYPO3com voted on patch set 2 V +1 04/18/20, 14:13 Completed build in 21m 23s on Sat, 18 Apr, 02:13 PM Test Summary: 73627 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2806

  10. Thomas Pronold rebased onto patch set 3 04/18/20, 16:55

  11. TYPO3com voted on patch set 3 V +1 04/18/20, 17:07 Completed build in 11m 51s on Sat, 18 Apr, 05:07 PM Test Summary: 73627 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2817

  12. Josef Glatz commented on patch set 3 CR -1 04/19/20, 08:11

    Didn‘t checked patch, but no feature without ChangeLog rST
  13. Josef Glatz commented on patch set 3 04/19/20, 08:13

    Also take care of being in sync: issue tracker on forge and commit message
  14. Alexander Schnitzler commented on patch set 3 04/19/20, 08:17

    Doesn't make sense rebasing this patch now as it won't be merged in master now. Let's put it aside and come back to it in 2 weeks or so.
  15. Oli Bartsch wrote 09/22/20, 11:28

    Removed reviewer Oliver Bartsch.
  16. Alexander Schnitzler commented on patch set 3 CR -1 09/22/20, 18:51

    Coming back to this patch I found several issues I have with it: * First of all I'd like to mention that the concept of an extension name is something that has been invented with Extbase. It's a fictional string that follows a pattern but it always has to be derived from the extension key which is the name of the folder in typo3conf/ext. Therefore I'd rather get rid of the extension name all along and have the user only deal with the key and if necessary convert it internally. * If we want to detect extension names and convert it, we can't do it again and again in several different classes on demand. We have to put this into a well tested helper class which has to be used everywhere. Extbase already has enough places where it does such a detection and it's not always the same algorithm.
  17. Benni Mack abandoned the change 11/05/21, 08:20

    I'll abandon this patch for the time being, as there was no activity (contacted Thomas directly)