Review main Merged

64228[TASK] Reduce inline JavaScript in ext:redirects and ext:scheduler

Oliver Hader CR +2 V +2 Normal +102 −26 updated 04/19/20, 19:48

Commit message

This change aims to reduce the amount of inline JavaScript by
moving these parts to dedicated static JavaScript modules or
using native HTML functionality instead of location.href.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 11

Review log 710

  1. Oliver Hader uploaded patch set 1 04/18/20, 12:18

  2. Oliver Hader wrote 04/18/20, 12:36

    Topic set to inline-javascript
  3. TYPO3com voted on patch set 1 V -1 04/18/20, 13:04 Completed build in 26m 09s on Sat, 18 Apr, 01:04 PM Test Summary: 2 of 74111 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2789

  4. TYPO3com commented on patch set 1 04/18/20, 13:39 Completed build in 1h 26m 56s on Sat, 18 Apr, 01:39 PM Test Summary: 2 of 74111 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2789

  5. Oliver Hader commented on patch set 1 04/18/20, 13:58

  6. Oliver Hader uploaded patch set 2 04/18/20, 14:05

  7. TYPO3com voted on patch set 2 V +1 04/18/20, 14:28 Completed build in 14m 26s on Sat, 18 Apr, 02:28 PM Test Summary: 73626 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2809

  8. Andreas Kienast voted on patch set 2 V +1 CR +1 04/19/20, 14:07

  9. Benni Mack voted on patch set 2 V +2 CR +2 04/19/20, 19:48

  10. Benni Mack merged patch set 3 04/19/20, 19:48