64228[TASK] Reduce inline JavaScript in ext:redirects and ext:scheduler
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Andreas Kienast +1
-
Verified V +2 Done
- Benni Mack +2
- Andreas Kienast +1
- TYPO3com +1 CI
Issues 1
Files 11
- Build/Sources/TypeScript/redirects/Resources/Public/TypeScript/EventHandler.ts+17 −0
- Build/Sources/TypeScript/redirects/Resources/Public/TypeScript/RedirectsModule.tsnew+56 −0
- Build/Sources/TypeScript/scheduler/Resources/Public/TypeScript/Scheduler.ts+7 −0
- typo3/sysext/redirects/Classes/Controller/ManagementController.php+1 −0
- typo3/sysext/redirects/Classes/Evaluation/SourceHost.php+1 −0
- typo3/sysext/redirects/Resources/Private/Partials/Pagination.html+1 −18
- typo3/sysext/redirects/Resources/Private/Templates/Management/Overview.html+2 −3
- typo3/sysext/redirects/Resources/Public/JavaScript/RedirectsModule.jsnew+13 −0
- typo3/sysext/scheduler/Classes/Controller/SchedulerModuleController.php+1 −2
- typo3/sysext/scheduler/Resources/Private/Templates/Backend/SchedulerModule/EditTask.html+2 −2
- typo3/sysext/scheduler/Resources/Public/JavaScript/Scheduler.js+1 −1
Review log 710
-
Oliver Hader uploaded patch set 1 04/18/20, 12:18
-
Oliver Hader wrote 04/18/20, 12:36
Topic set to inline-javascript -
TYPO3com voted on patch set 1 V -1 04/18/20, 13:04 Completed build in 26m 09s on Sat, 18 Apr, 01:04 PM Test Summary: 2 of 74111 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2789
-
TYPO3com commented on patch set 1 04/18/20, 13:39 Completed build in 1h 26m 56s on Sat, 18 Apr, 01:39 PM Test Summary: 2 of 74111 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2789
-
Oliver Hader commented on patch set 1 04/18/20, 13:58
> 13:38:14.948 SEVERE - http://web:8000/typo3temp/var/tests/acceptance/typo3/sysext/core/Resources/Public/JavaScript/Event/RegularEvent.js?bust=42de89193f757f23b1e85887ff48e73087b79151 12:152 Uncaught TypeError: Cannot read property 'addEventListener' of null -
Oliver Hader uploaded patch set 2 04/18/20, 14:05
-
TYPO3com voted on patch set 2 V +1 04/18/20, 14:28 Completed build in 14m 26s on Sat, 18 Apr, 02:28 PM Test Summary: 73626 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2809
-
Andreas Kienast voted on patch set 2 V +1 CR +1 04/19/20, 14:07
-
Benni Mack voted on patch set 2 V +2 CR +2 04/19/20, 19:48
-
Benni Mack merged patch set 3 04/19/20, 19:48