64229[TASK] Remove superfluous onclick events in FormEngine
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Oli Bartsch +1
- Oliver Klee +1
- Jonas Eberle +1
- Alexander Schnitzler +1
-
Verified V +2 Done
- Oliver Hader +2
- Oli Bartsch +1
- Jonas Eberle +1
- Alexander Schnitzler +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1011
-
Oliver Hader uploaded patch set 1 04/18/20, 12:22
-
Oliver Klee voted on patch set 1 CR +1 04/18/20, 12:28
-
Oliver Hader wrote 04/18/20, 12:36
Topic set to inline-javascript -
TYPO3com voted on patch set 1 V +1 04/18/20, 12:54 Completed build in 15m 56s on Sat, 18 Apr, 12:54 PM Test Summary: 73627 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2790
-
Jonas Eberle commented on patch set 1 V +1 CR +1 04/18/20, 14:17
InlineControlContainer.php:631This was not used any more anyways, was it? -
Oliver Hader commented on patch set 1 04/18/20, 15:23
InlineControlContainer.php:631ReplyCorrect... the variable was uninitialized long time... and some automated code-clean up then introduced the empty variable again - instead of actually adjusting the code... -
Alexander Schnitzler voted on patch set 1 V +1 CR +1 04/18/20, 15:36
-
Oli Bartsch voted on patch set 1 V +1 CR +1 04/18/20, 16:23
-
Jonas Eberle commented on patch set 1 04/18/20, 16:32
InlineControlContainer.php:631ReplyDone -
Oliver Hader voted on patch set 1 V +2 CR +2 04/18/20, 16:45
-
Oliver Hader merged patch set 2 04/18/20, 16:45