Review main Merged

64230[TASK] Reduce inline JavaScript in QueryView

Oliver Hader CR +2 V +2 Easy +12 −16 updated 04/20/20, 12:00

Commit message

This change aims to reduce the amount of inline JavaScript by
moving these parts to dedicated static JavaScript modules or
using native HTML functionality instead of location.href.

* unused properties in QueryView have been removed
* onclick event on a submit button does not have any effect
  since the onsubmit event is handled first - corresponding
  code has been removed as well

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • Josef Glatz +1
    • Benni Mack +1
  • Verified V +2 Done
    • Frank Nägler +2
    • Josef Glatz +1
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 89

  1. Oliver Hader uploaded patch set 1 04/18/20, 12:26

  2. Oliver Hader wrote 04/18/20, 12:36

    Topic set to inline-javascript
  3. TYPO3com voted on patch set 1 V +1 04/18/20, 13:09 Completed build in 30m 43s on Sat, 18 Apr, 01:09 PM Test Summary: 73627 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2791

  4. Benni Mack voted on patch set 1 CR +1 04/19/20, 19:50

  5. Benni Mack voted on patch set 1 V +1 04/20/20, 10:31

  6. Frank Nägler voted on patch set 1 CR +1 04/20/20, 11:43

  7. Josef Glatz voted on patch set 1 V +1 CR +1 04/20/20, 11:52

  8. Frank Nägler voted on patch set 1 V +2 CR +2 04/20/20, 12:00

  9. Frank Nägler merged patch set 2 04/20/20, 12:00