Review main Merged

64234[BUGFIX] Avoid using the symfony container to clear its own caches

Benjamin Franzke CR +2 V +2 Easy +26 −7 updated 04/19/20, 13:12

Commit message

With the introduction of a custom DI cache in #90418, the container
was used to lookup its own cache and the cache identifier. This
results in bugs if the container cache is stale:
Loading from the cache and flushing the cache will work, but code that
runs after the cache has been flushed (ext_localconf loading) will still
use the a stale container (configuration), as the instance has been
created too early (to be able to clear itself).

Therefore we do now avoid instantiating the symfony container before the
container cache has been cleared.

A positive side effect of this change is that the container cache is
warmed up after the flush.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Susi Moog +1
    • Helmut Hummel +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Jonas Eberle +1
    • Helmut Hummel +1
    • TYPO3com +1 CI

Issues 2

Files 3

Review log 1418

  1. Benjamin Franzke uploaded patch set 1 04/18/20, 13:03

  2. TYPO3com voted on patch set 1 V -1 04/18/20, 13:33 Completed build in 29m 33s on Sat, 18 Apr, 01:33 PM Test Summary: 477 of 53524 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2799

  3. TYPO3com voted on patch set 1 V +1 04/18/20, 14:25 Completed build in 22m 42s on Sat, 18 Apr, 02:25 PM Test Summary: 73626 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2808

  4. Jonas Eberle commented on patch set 1 V +1 04/18/20, 14:32

    This is pure magic to me, but it fixes the problem. Thank you! Test failure seems unrelated: Some TS-linting and Webdriver-Timeouts
  5. Jonas Eberle commented on patch set 1 04/18/20, 14:33

    Ah, nevermind. Tests were already retriggered and are green.
  6. Benjamin Franzke uploaded patch set 2 04/18/20, 18:41

  7. Helmut Hummel voted on patch set 2 V +1 CR +1 04/18/20, 18:46

  8. Jonas Eberle voted on patch set 2 V +1 04/18/20, 18:54

  9. TYPO3com voted on patch set 2 V +1 04/18/20, 18:55 Completed build in 13m 48s on Sat, 18 Apr, 06:55 PM Test Summary: 73627 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2820

  10. Markus Klein commented on patch set 2 04/18/20, 20:09

    ClearCacheService.php:80

    needs the variable name
  11. Benjamin Franzke uploaded patch set 3 04/18/20, 21:23

  12. Benjamin Franzke commented on patch set 3 04/18/20, 21:24

    ClearCacheService.php:80 Reply

    Ack
  13. Jonas Eberle commented on patch set 3 V +1 04/18/20, 21:25

    ClearCacheService.php:80 Reply

    Done
  14. TYPO3com voted on patch set 3 V +1 04/18/20, 21:34 Completed build in 11m 08s on Sat, 18 Apr, 09:34 PM Test Summary: 73627 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2827

  15. Susi Moog voted on patch set 3 CR +1 04/19/20, 06:10

  16. Helmut Hummel voted on patch set 3 V +1 CR +1 04/19/20, 13:01

  17. Benjamin Franzke voted on patch set 3 V +2 CR +2 04/19/20, 13:12

  18. Benjamin Franzke merged patch set 4 04/19/20, 13:12