Review main Merged

64238[TASK] Get rid of "PHP Notice: Undefined index" notices

Thomas Pronold CR +2 V +2 Normal +93 −88 updated 01/04/21, 12:49

Commit message

Running a clean installation minimal setup throws
a lot of "PHP Notice: Undefined index: " notices.
This commit removes the ones from the frontend.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 20

Review log 1825

  1. Thomas Pronold uploaded patch set 1 04/18/20, 16:55

  2. TYPO3com voted on patch set 1 V -1 04/18/20, 16:56 Completed build in 42s on Sat, 18 Apr, 04:56 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2818

  3. Tymoteusz Motylewski commented on patch set 1 04/25/20, 17:05

    Hi Looks like the patch contains some CGL violations. Run Build/Scripts/cglFixMyCommit.sh and push a new patch version
  4. Thomas Pronold uploaded patch set 2 04/30/20, 15:33

  5. Thomas Pronold uploaded patch set 3 04/30/20, 16:02

  6. Thomas Pronold uploaded patch set 4 04/30/20, 16:08

  7. TYPO3com voted on patch set 3 V -1 04/30/20, 16:22 Completed build in 18m 47s on Thu, 30 Apr, 04:22 PM Test Summary: 1 of 74131 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3127

  8. TYPO3com voted on patch set 4 V +1 04/30/20, 16:41 Completed build in 30m 12s on Thu, 30 Apr, 04:41 PM Test Summary: 73662 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3128

  9. Susi Moog voted on patch set 4 CR +1 05/22/20, 20:17

  10. Benni Mack updated the commit message in patch set 5 05/25/20, 18:53

  11. Benni Mack uploaded patch set 6 01/04/21, 07:31

  12. TYPO3com voted on patch set 6 V -1 01/04/21, 07:41 Completed build in 10m 00s on Mon, 4 Jan, 07:41 AM Test Summary: 1 of 32787 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8576

  13. TYPO3com voted on patch set 6 V +1 01/04/21, 08:18 Completed build in 56m 58s on Mon, 4 Jan, 08:18 AM Test Summary: 32546 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8576

  14. Benjamin Franzke commented on patch set 6 01/04/21, 08:24

    LanguageMenuProcessor.php:453

    maybe this should be: ?? '' stdWrap() expects a string and typecasts to string anyway.
  15. Benni Mack commented on patch set 6 01/04/21, 08:25

    on it
  16. Benjamin Franzke commented on patch set 6 01/04/21, 08:26

    LanguageMenuProcessor.php:453 Reply

    Nevermind, commented on an old patchset by accident. Sorry.
  17. Benni Mack uploaded patch set 7 01/04/21, 08:45

  18. TYPO3com voted on patch set 7 V +1 01/04/21, 08:56 Completed build in 10m 42s on Mon, 4 Jan, 08:55 AM Test Summary: 32546 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8578

  19. Benni Mack uploaded patch set 8 01/04/21, 09:31

  20. TYPO3com voted on patch set 8 V +1 01/04/21, 09:43 Completed build in 11m 56s on Mon, 4 Jan, 09:43 AM Test Summary: 32546 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8580

  21. Benni Mack voted on patch set 8 V +1 CR +1 01/04/21, 10:05

  22. Oli Bartsch commented on patch set 8 CR -1 01/04/21, 11:38

    On it
  23. Oli Bartsch voted on patch set 8 V +1 CR +1 01/04/21, 12:44

  24. Benni Mack voted on patch set 8 V +2 CR +2 01/04/21, 12:49

  25. Benni Mack merged patch set 9 01/04/21, 12:49