64239[BUGFIX] Add FIRST_INSTALL to .gitignore
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Josef Glatz +1
-
Verified V +2 Done
- Benni Mack +2
- Josef Glatz +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1924
-
Thomas Pronold uploaded patch set 1 04/18/20, 17:03
-
Oliver Klee commented on patch set 1 04/18/20, 17:12
-
TYPO3com voted on patch set 1 V -1 04/18/20, 17:16 Completed build in 12m 54s on Sat, 18 Apr, 05:16 PM Test Summary: 1 of 74112 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2819
-
Thomas Pronold commented on patch set 1 04/18/20, 17:18
.gitignore:60Reply UnresolvedWorks both ways. See line 67 -
Tymoteusz Motylewski commented on patch set 1 04/20/20, 19:14
sure both works. The difference is that with a slash only the file in root folder is being considered, while without slash, the file can be in any subfolder. see https://www.atlassian.com/git/tutorials/saving-changes/gitignore#git-ignore-patterns The question is whether you tried to achieve the first or the second case? -
Josef Glatz commented on patch set 2 04/21/20, 03:01
Published edit on patch set 1. -
Josef Glatz voted on patch set 2 V +1 CR +1 04/21/20, 03:01
-
TYPO3com voted on patch set 2 V -1 04/21/20, 03:13 Completed build in 11m 47s on Tue, 21 Apr, 03:13 AM Test Summary: 1 of 73821 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2931
-
TYPO3com commented on patch set 2 04/21/20, 05:32 Completed build in 2h 42m 14s on Tue, 21 Apr, 05:32 AM Test Summary: 73343 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2931
-
TYPO3com voted on patch set 2 V +1 04/21/20, 06:12 Completed build in 5h 53m 04s on Tue, 21 Apr, 06:12 AM Test Summary: 73657 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2931
-
Simon Gilli voted on patch set 2 V +1 CR +1 04/21/20, 06:26
-
Thomas Pronold commented on patch set 2 04/21/20, 06:28
> Patch Set 1: > > sure both works. > The difference is that with a slash only the file in root folder is being considered, while without slash, the file can be in any subfolder. > see > https://www.atlassian.com/git/tutorials/saving-changes/gitignore#git-ignore-patterns > The question is whether you tried to achieve the first or the second case? Sure, you are right. I meant a root folder ignore ofc. Sb. else changed it already. All good. :) -
Wouter Wolters voted on patch set 2 CR +1 04/21/20, 06:59
-
Benni Mack commented on patch set 2 CR -1 04/21/20, 12:44
Can somebody give me a quick reason why this is necessary? Don't get it from commit message nor from the ticket. -
Josef Glatz commented on patch set 2 04/23/20, 07:17
> Patch Set 2: Code-Review-1 > > Can somebody give me a quick reason why this is necessary? Don't get it from commit message nor from the ticket. From my perspective * it's a nice to have * and it prevents somebody from adding it to any core patch with `git commit -am "[TASK] patchi patchi" > So it doesn't hurt when it's in the .gitignore -
Simon Gilli commented on patch set 2 04/24/20, 13:36
> Patch Set 2: > > > Patch Set 2: Code-Review-1 > > > > Can somebody give me a quick reason why this is necessary? Don't get it from commit message nor from the ticket. > > From my perspective > * it's a nice to have > * and it prevents somebody from adding it to any core patch with `git commit -am "[TASK] patchi patchi" > > > So it doesn't hurt when it's in the .gitignore Same reason here. But agree, the description should be better... -
Benni Mack updated the commit message in patch set 3 05/25/20, 18:48
-
Benni Mack voted on patch set 3 V +1 CR +1 05/25/20, 18:48
-
Josef Glatz voted on patch set 3 V +1 CR +1 05/25/20, 18:49
-
Benni Mack updated the commit message in patch set 4 05/26/20, 06:51
-
TYPO3com voted on patch set 4 V +1 05/26/20, 07:02 Completed build in 10m 54s on Tue, 26 May, 07:02 AM Test Summary: 73808 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3552
-
Josef Glatz voted on patch set 4 V +1 CR +1 05/26/20, 07:16
-
Benni Mack voted on patch set 4 V +2 CR +2 05/26/20, 08:11
-
Benni Mack merged patch set 5 05/26/20, 08:11
.gitignore:60