Review main Merged

64240[TASK] Remove superfluous inline JavaScript assignment in ext:beuser

Oliver Hader CR +2 V +2 Easy +0 −8 updated 04/19/20, 15:04

Commit message

Fluid variable `previewUrl` is generated, but never used in templates.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Wouter Wolters +1
    • Guido Schmechel +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 78

  1. Oliver Hader uploaded patch set 1 04/18/20, 20:31

  2. TYPO3com voted on patch set 1 V +1 04/18/20, 20:43 Completed build in 11m 20s on Sat, 18 Apr, 08:43 PM Test Summary: 73627 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2821

  3. Oliver Hader wrote 04/18/20, 21:04

    Topic set to inline-javascript
  4. Wouter Wolters voted on patch set 1 CR +1 04/19/20, 11:49

  5. Guido Schmechel voted on patch set 1 CR +1 04/19/20, 13:28

  6. Andreas Kienast voted on patch set 1 V +1 CR +1 04/19/20, 14:03

  7. Oliver Hader voted on patch set 1 V +2 CR +2 04/19/20, 15:04

  8. Oliver Hader merged patch set 2 04/19/20, 15:04