Review main Merged

64241[FEATURE] Introduce DocumentService as JQuery.ready substitute

Oliver Hader CR +2 V +2 Normal +116 −18 updated 04/19/20, 19:18

Commit message

Module TYPO3/CMS/Core/DocumentService provides native JavaScript
functions to detect DOM ready-state returning a Promise<Document>.

`$(document).ready(() => {...});` can be replaced by
`documentService.ready().then(() => {...});`

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Andreas Kienast +1
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 1116

  1. Oliver Hader uploaded patch set 1 04/18/20, 20:41

  2. TYPO3com voted on patch set 1 V +1 04/18/20, 20:53 Completed build in 11m 20s on Sat, 18 Apr, 08:53 PM Test Summary: 73627 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2822

  3. Oliver Hader uploaded patch set 2 04/18/20, 21:02

  4. Oliver Hader wrote 04/18/20, 21:03

    Topic set to inline-javascript
  5. TYPO3com commented on patch set 2 04/18/20, 21:14 Completed build in 11m 21s on Sat, 18 Apr, 09:14 PM Test Summary: 73627 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2823

  6. Andreas Kienast voted on patch set 2 V +1 CR +1 04/19/20, 08:23

  7. Oliver Hader uploaded patch set 3 04/19/20, 08:51

  8. Andreas Kienast commented on patch set 3 CR -1 04/19/20, 08:54

    on it
  9. Andreas Kienast uploaded patch set 4 04/19/20, 08:57

  10. Andreas Kienast voted on patch set 4 V +1 CR +1 04/19/20, 08:57

  11. TYPO3com voted on patch set 3 V -1 04/19/20, 09:15 Completed build in 24m 03s on Sun, 19 Apr, 09:15 AM Test Summary: 19 of 72178 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2830

  12. TYPO3com voted on patch set 4 V -1 04/19/20, 09:43 Completed build in 29m 51s on Sun, 19 Apr, 09:43 AM Test Summary: 12 of 74111 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2831

  13. TYPO3com voted on patch set 4 V +1 04/19/20, 09:55 Completed build in 1h 11m 37s on Sun, 19 Apr, 09:55 AM Test Summary: 73627 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2831

  14. Oliver Hader voted on patch set 4 V +2 CR +2 04/19/20, 10:00

  15. Oliver Hader merged patch set 5 04/19/20, 10:00

  16. Benni Mack voted on patch set 5 V +1 CR +1 04/19/20, 19:18