64242[TASK] Use GlobalEventHandler and ActionDispatcher instead of inline JS
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Josef Glatz +1
- Benni Mack +1
-
Verified V +2 Done
- Oliver Hader +2
- Josef Glatz +1
- Benni Mack +1
- TYPO3com +1 CI
Issues 1
Files 18
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/ActionDispatcher.ts+16 −8
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/GlobalEventHandler.ts+13 −11
- typo3/sysext/backend/Classes/Clipboard/Clipboard.php+8 −2
- typo3/sysext/backend/Classes/Controller/Wizard/TableController.php+1 −2
- typo3/sysext/backend/Classes/Template/DocumentTemplate.php1+2 −0
- typo3/sysext/backend/Classes/Utility/BackendUtility.php1+44 −20
- typo3/sysext/backend/Classes/View/PageLayoutView.php+1 −1
- typo3/sysext/backend/Resources/Private/Partials/Clipboard/TabContent.html+4 −2
- typo3/sysext/backend/Resources/Private/Partials/PageLayout/LanguageColumns.html+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/ActionDispatcher.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/GlobalEventHandler.js+1 −1
- typo3/sysext/core/Classes/Database/QueryView.php+6 −3
- typo3/sysext/core/Classes/Utility/GeneralUtility.php+11 −0
- typo3/sysext/core/Documentation/Changelog/10.4.x/Important-91117-UseGlobalEventHandlerAndActionDispatcherInsteadOfInlineJS.rstnew+76 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Be/TableListViewHelper.php+1 −0
- typo3/sysext/info/Classes/Controller/InfoPageTyposcriptConfigController.php+1 −2
- typo3/sysext/recordlist/Classes/Controller/RecordListController.php+1 −1
- typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php+18 −8
Review log 2737
Show 1012 earlier messages
-
Oliver Hader uploaded patch set 1 04/18/20, 21:02
-
Oliver Hader wrote 04/18/20, 21:03
Topic set to inline-javascript -
TYPO3com voted on patch set 1 V -1 04/18/20, 21:20 Completed build in 17m 02s on Sat, 18 Apr, 09:20 PM Test Summary: 75 of 74111 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2825
-
Oliver Hader commented on patch set 1 04/18/20, 21:32
-
Oliver Hader commented on patch set 1 CR -1 04/19/20, 10:17
ModuleTemplate.php:259Unresolved -
Oliver Hader commented on patch set 1 04/19/20, 11:02
DocumentTemplate.php:329Unresolvedwrong attributeModuleTemplate.php:562Unresolvedwrong attribute -
Oliver Hader uploaded patch set 2 04/20/20, 09:36
-
Oliver Hader voted on patch set 2 CR -1 04/20/20, 09:42
-
Oliver Hader commented on patch set 2 04/20/20, 09:55
BackendUtility.php:2703Unresolvedhandling is missing in GlobelEventHandler -
Oliver Hader uploaded patch set 3 04/20/20, 10:21
-
Oliver Hader commented on patch set 3 04/20/20, 10:23
Now good to go & tested -
TYPO3com voted on patch set 3 V -1 04/20/20, 10:33 Completed build in 12m 16s on Mon, 20 Apr, 10:33 AM Test Summary: 1 of 74111 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2885
-
TYPO3com commented on patch set 3 04/20/20, 10:47 Completed build in 38m 41s on Mon, 20 Apr, 10:47 AM Test Summary: 1 of 74111 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2885
-
Oliver Hader commented on patch set 3 04/20/20, 11:00
> 10:47:34.138 SEVERE - http://web:8000/typo3temp/var/tests/acceptance/typo3/index.php?route=%2Fmodule%2Fsystem%2FtxschedulerM1&token=de7efa0ea0a4362205d40c96bad2e84cc4e5a581 0:1 Uncaught SyntaxError: Unexpected token & in JSON at position 1 -
Oliver Hader uploaded patch set 4 04/20/20, 14:00
-
TYPO3com voted on patch set 4 V -1 04/20/20, 14:14 Completed build in 13m 15s on Mon, 20 Apr, 02:14 PM Test Summary: 1 of 74141 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2897
-
Oliver Hader uploaded patch set 5 04/20/20, 14:26
-
Oliver Hader commented on patch set 5 04/20/20, 14:28
I did not manage to fix those Shortcut module issues and kept receiving (unrelated?) Ajax errors and Object casting/flattening errors... that's why I removed shortcut handling from this changeset. -
TYPO3com voted on patch set 5 V -1 04/20/20, 14:45 Completed build in 14m 34s on Mon, 20 Apr, 02:45 PM Test Summary: 75 of 74141 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2901
-
Oliver Hader uploaded patch set 6 04/20/20, 14:58
-
TYPO3com voted on patch set 6 V -1 04/20/20, 15:11 Completed build in 12m 44s on Mon, 20 Apr, 03:11 PM Test Summary: 73657 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2906
-
Oliver Hader uploaded patch set 7 04/20/20, 15:13
-
TYPO3com voted on patch set 7 V -1 04/20/20, 15:25 Completed build in 12m 11s on Mon, 20 Apr, 03:25 PM Test Summary: 73657 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2907
-
Oliver Hader uploaded patch set 8 04/20/20, 15:36
-
TYPO3com voted on patch set 8 V +1 04/20/20, 15:48 Completed build in 11m 49s on Mon, 20 Apr, 03:48 PM Test Summary: 73657 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2910
-
Markus Klein voted on patch set 8 CR +1 04/20/20, 17:41
-
Benni Mack voted on patch set 8 V +1 CR +1 04/20/20, 19:59
-
Josef Glatz voted on patch set 8 CR +1 04/21/20, 07:22
-
Josef Glatz voted on patch set 8 V +1 04/21/20, 07:41
-
Oliver Hader uploaded patch set 9 04/22/20, 08:49
-
Oliver Hader commented on patch set 9 04/22/20, 08:49
→ moved RST file to corresponding folder -
Josef Glatz voted on patch set 9 V +1 CR +1 04/22/20, 08:50
-
Benni Mack voted on patch set 9 V +1 CR +1 04/22/20, 08:55
-
TYPO3com voted on patch set 9 V -1 04/22/20, 09:08 Completed build in 17m 16s on Wed, 22 Apr, 09:08 AM Test Summary: 1 of 74141 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2974
-
TYPO3com voted on patch set 9 V +1 04/22/20, 09:28 Completed build in 54m 15s on Wed, 22 Apr, 09:28 AM Test Summary: 73655 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2974
-
Oliver Hader voted on patch set 9 V +2 CR +2 04/22/20, 09:28
-
Oliver Hader merged patch set 10 04/22/20, 09:28