Review main Merged

64242[TASK] Use GlobalEventHandler and ActionDispatcher instead of inline JS

Oliver Hader CR +2 V +2 Hard +206 −63 updated 04/22/20, 09:28

Commit message

This change aims to reduce the amount of inline JavaScript by
removing `onchange` or `onclick` events and dynamically created
JavaScript code/settings.

* adjusts invocations of top.TYPO3.InfoWindow.showItem
* adjusts low-level inline `onchange` and `onclick` events

Both JavaScript modules `TYPO3/CMS/Backend/GlobalEventHandler` and
`TYPO3/CMS/Backend/ActionDispatcher` are required to actually handle
these new triggers and correpsonding events - that's why they are
loaded in `ModuleTemplate` and deprecated `DocumentTemplate`.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Josef Glatz +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Josef Glatz +1
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 18

Review log 2737

Show 1012 earlier messages
  1. Oliver Hader uploaded patch set 1 04/18/20, 21:02

  2. Oliver Hader wrote 04/18/20, 21:03

    Topic set to inline-javascript
  3. TYPO3com voted on patch set 1 V -1 04/18/20, 21:20 Completed build in 17m 02s on Sat, 18 Apr, 09:20 PM Test Summary: 75 of 74111 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2825

  4. Oliver Hader commented on patch set 1 04/18/20, 21:32

  5. Oliver Hader commented on patch set 1 CR -1 04/19/20, 10:17

    ModuleTemplate.php:259 Unresolved

  6. Oliver Hader commented on patch set 1 04/19/20, 11:02

    DocumentTemplate.php:329 Unresolved

    wrong attribute

    ModuleTemplate.php:562 Unresolved

    wrong attribute
  7. Oliver Hader uploaded patch set 2 04/20/20, 09:36

  8. Oliver Hader voted on patch set 2 CR -1 04/20/20, 09:42

  9. Oliver Hader commented on patch set 2 04/20/20, 09:55

    BackendUtility.php:2703 Unresolved

    handling is missing in GlobelEventHandler
  10. Oliver Hader uploaded patch set 3 04/20/20, 10:21

  11. Oliver Hader commented on patch set 3 04/20/20, 10:23

    Now good to go & tested
  12. TYPO3com voted on patch set 3 V -1 04/20/20, 10:33 Completed build in 12m 16s on Mon, 20 Apr, 10:33 AM Test Summary: 1 of 74111 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2885

  1. TYPO3com commented on patch set 3 04/20/20, 10:47 Completed build in 38m 41s on Mon, 20 Apr, 10:47 AM Test Summary: 1 of 74111 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2885

  2. Oliver Hader commented on patch set 3 04/20/20, 11:00

  3. Oliver Hader uploaded patch set 4 04/20/20, 14:00

  4. TYPO3com voted on patch set 4 V -1 04/20/20, 14:14 Completed build in 13m 15s on Mon, 20 Apr, 02:14 PM Test Summary: 1 of 74141 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2897

  5. Oliver Hader uploaded patch set 5 04/20/20, 14:26

  6. Oliver Hader commented on patch set 5 04/20/20, 14:28

    I did not manage to fix those Shortcut module issues and kept receiving (unrelated?) Ajax errors and Object casting/flattening errors... that's why I removed shortcut handling from this changeset.
  7. TYPO3com voted on patch set 5 V -1 04/20/20, 14:45 Completed build in 14m 34s on Mon, 20 Apr, 02:45 PM Test Summary: 75 of 74141 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2901

  8. Oliver Hader uploaded patch set 6 04/20/20, 14:58

  9. TYPO3com voted on patch set 6 V -1 04/20/20, 15:11 Completed build in 12m 44s on Mon, 20 Apr, 03:11 PM Test Summary: 73657 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2906

  10. Oliver Hader uploaded patch set 7 04/20/20, 15:13

  11. TYPO3com voted on patch set 7 V -1 04/20/20, 15:25 Completed build in 12m 11s on Mon, 20 Apr, 03:25 PM Test Summary: 73657 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2907

  12. Oliver Hader uploaded patch set 8 04/20/20, 15:36

  13. TYPO3com voted on patch set 8 V +1 04/20/20, 15:48 Completed build in 11m 49s on Mon, 20 Apr, 03:48 PM Test Summary: 73657 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2910

  14. Markus Klein voted on patch set 8 CR +1 04/20/20, 17:41

  15. Benni Mack voted on patch set 8 V +1 CR +1 04/20/20, 19:59

  16. Josef Glatz voted on patch set 8 CR +1 04/21/20, 07:22

  17. Josef Glatz voted on patch set 8 V +1 04/21/20, 07:41

  18. Oliver Hader uploaded patch set 9 04/22/20, 08:49

  19. Oliver Hader commented on patch set 9 04/22/20, 08:49

    → moved RST file to corresponding folder
  20. Josef Glatz voted on patch set 9 V +1 CR +1 04/22/20, 08:50

  21. Benni Mack voted on patch set 9 V +1 CR +1 04/22/20, 08:55

  22. TYPO3com voted on patch set 9 V -1 04/22/20, 09:08 Completed build in 17m 16s on Wed, 22 Apr, 09:08 AM Test Summary: 1 of 74141 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2974

  23. TYPO3com voted on patch set 9 V +1 04/22/20, 09:28 Completed build in 54m 15s on Wed, 22 Apr, 09:28 AM Test Summary: 73655 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2974

  24. Oliver Hader voted on patch set 9 V +2 CR +2 04/22/20, 09:28

  25. Oliver Hader merged patch set 10 04/22/20, 09:28