64243[TASK] Avoid inline JavaScript generated by BackendUtility:viewOnClick
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Andreas Kienast +1
-
Verified V +2 Done
- Benni Mack +2
- Andreas Kienast +1
- TYPO3com +1 CI
Issues 1
Files 35
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/Element/ImmediateActionElement.ts1+16 −3
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/ActionDispatcher.ts2+5 −11
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/Utility.ts+14 −0
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/WindowManager.ts4new+63 −0
- Build/Sources/TypeScript/workspaces/Resources/Public/TypeScript/Backend.ts1+7 −6
- Build/types/TYPO3/index.d.ts+1 −0
- typo3/sysext/backend/Classes/Controller/ContentElement/ElementInformationController.php+5 −2
- typo3/sysext/backend/Classes/Controller/Page/NewMultiplePagesController.php+5 −1
- typo3/sysext/backend/Classes/Controller/Page/SortSubPagesController.php+5 −1
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php+19 −38
- typo3/sysext/backend/Classes/Controller/NewRecordController.php+5 −5
- typo3/sysext/backend/Classes/Controller/PageLayoutController.php3+6 −9
- typo3/sysext/backend/Classes/Routing/PreviewUriBuilder.phpnew+324 −0
- typo3/sysext/backend/Classes/View/BackendLayout/Grid/LanguageColumn.php+7 −9
- typo3/sysext/backend/Classes/View/PageLayoutView.php+6 −9
- typo3/sysext/backend/Resources/Private/Partials/PageLayout/LanguageColumns.html+1 −1
- typo3/sysext/backend/Resources/Private/Templates/ContentElement/ElementInformation.html+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/Element/ImmediateActionElement.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/ActionDispatcher.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/Utility.js+1 −1
Show 15 more files
- typo3/sysext/backend/Resources/Public/JavaScript/WindowManager.jsnew+13 −0
- typo3/sysext/backend/Tests/Unit/Routing/PreviewUriBuilderTest.phpnew+49 −0
- typo3/sysext/core/Documentation/Changelog/10.4.x/Important-91123-AvoidUsingBackendUtilityViewOnClick.rstnew+59 −0
- typo3/sysext/impexp/Classes/Controller/ImportController.php+5 −6
- typo3/sysext/impexp/Classes/ImportExport.php+4 −2
- typo3/sysext/info/Classes/Controller/InfoModuleController.php+5 −5
- typo3/sysext/info/Classes/Controller/PageInformationController.php+5 −3
- typo3/sysext/info/Classes/Controller/TranslationStatusController.php+8 −20
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallStaticMatcher.php+7 −0
- typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php+22 −29
- typo3/sysext/tstemplate/Classes/Controller/TypoScriptTemplateModuleController.php+5 −5
- typo3/sysext/workspaces/Classes/Event/RetrievedPreviewUrlEvent.phpnew+110 −0
- typo3/sysext/workspaces/Classes/Preview/PreviewUriBuilder.php+36 −23
- typo3/sysext/workspaces/Configuration/Services.yaml+7 −0
- typo3/sysext/workspaces/Resources/Public/JavaScript/Backend.js+1 −1
Review log 3756
Show 1931 earlier messages
-
Oliver Hader uploaded patch set 1 04/18/20, 21:02
-
Oliver Hader wrote 04/18/20, 21:03
Topic set to inline-javascript -
TYPO3com voted on patch set 1 V -1 04/18/20, 21:03 Completed build in 20s on Sat, 18 Apr, 09:03 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2826
-
Oliver Hader marked it work in progress 04/18/20, 21:04
-
Oliver Hader uploaded patch set 2 04/22/20, 09:31
-
TYPO3com voted on patch set 2 V -1 04/22/20, 09:32 Completed build in 31s on Wed, 22 Apr, 09:32 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2976
-
Oliver Hader uploaded patch set 3 04/22/20, 09:35
-
Oliver Hader commented on patch set 3 V -1 04/22/20, 09:38
New page layout stuff fails... -
Oliver Hader uploaded patch set 4 04/22/20, 09:43
-
TYPO3com voted on patch set 3 V -1 04/22/20, 09:44 Completed build in 08m 25s on Wed, 22 Apr, 09:44 AM Test Summary: 186 of 70283 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2978
-
TYPO3com voted on patch set 4 V -1 04/22/20, 09:47 Completed build in 03m 54s on Wed, 22 Apr, 09:47 AM Test Summary: 52737 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2979
-
Oliver Hader uploaded patch set 5 04/22/20, 09:50
-
Oliver Hader commented on patch set 5 04/22/20, 09:50
This change is ready for review. -
TYPO3com voted on patch set 5 V -1 04/22/20, 10:02 Completed build in 11m 55s on Wed, 22 Apr, 10:02 AM Test Summary: 28 of 74141 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2980
-
TYPO3com commented on patch set 5 04/22/20, 10:15 Completed build in 36m 55s on Wed, 22 Apr, 10:15 AM Test Summary: 27 of 74141 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2980
-
TYPO3com commented on patch set 5 04/22/20, 11:08 Completed build in 1h 55m 16s on Wed, 22 Apr, 11:08 AM Test Summary: 27 of 74141 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2980
-
Oliver Hader uploaded patch set 6 04/22/20, 11:39
-
TYPO3com voted on patch set 6 V +1 04/22/20, 11:50 Completed build in 11m 42s on Wed, 22 Apr, 11:50 AM Test Summary: 73657 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2984
-
Oliver Hader uploaded patch set 7 04/25/20, 08:43
-
TYPO3com voted on patch set 7 V +1 04/25/20, 08:57 Completed build in 13m 39s on Sat, 25 Apr, 08:57 AM Test Summary: 73657 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3025
-
Jonas Eberle commented on patch set 7 V +1 04/26/20, 10:47
Sweet! I love it. -
Oliver Hader commented on patch set 7 CR -1 07/13/20, 11:28
Requires https://review.typo3.org/c/Packages/TYPO3.CMS/+/64675 to be merged first (since it will be based on that "immediate action" handling) -
Oliver Hader uploaded patch set 8 07/15/20, 22:09
-
TYPO3com voted on patch set 8 V -1 07/15/20, 22:09 Completed build in 29s on Wed, 15 Jul, 10:09 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4106
-
Oliver Hader uploaded patch set 9 07/15/20, 22:20
-
TYPO3com voted on patch set 9 V -1 07/15/20, 22:32 Completed build in 12m 00s on Wed, 15 Jul, 10:32 PM Test Summary: 7 of 73432 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4110
-
Andreas Kienast commented on patch set 9 07/16/20, 06:18
WindowManager.ts:25You may use `windowName: string = 'previewWin'` here -
TYPO3com commented on patch set 9 07/16/20, 06:35 Completed build in 8h 26m 40s on Thu, 16 Jul, 06:35 AM Test Summary: 6 of 73432 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4110
-
Oliver Hader voted on patch set 9 CR -1 07/16/20, 08:19
-
Oliver Hader uploaded patch set 10 07/16/20, 09:00
-
Oliver Hader commented on patch set 10 07/16/20, 09:02
WindowManager.ts:25Reply UnresolvedThx, switched to `newTYPO3frontendWindow` which was the default of `BackendUtility::viewOnClick`
-
TYPO3com voted on patch set 10 V +1 07/16/20, 09:12 Completed build in 11m 42s on Thu, 16 Jul, 09:12 AM Test Summary: 72951 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4111
-
Andreas Kienast uploaded patch set 11 07/16/20, 11:21
-
TYPO3com voted on patch set 11 V +1 07/16/20, 11:33 Completed build in 11m 58s on Thu, 16 Jul, 11:33 AM Test Summary: 72951 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4112
-
Andreas Kienast voted on patch set 11 V +1 CR +1 07/16/20, 11:49
-
Oliver Hader voted on patch set 11 CR -1 07/17/20, 14:37
-
Oliver Hader uploaded patch set 12 07/17/20, 14:39
-
Oliver Hader commented on patch set 12 07/17/20, 14:40
Adjusted for nitpick comment in 10.4 branch -
TYPO3com voted on patch set 12 V +1 07/17/20, 14:50 Completed build in 11m 40s on Fri, 17 Jul, 02:50 PM Test Summary: 72951 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4134
-
Andreas Kienast uploaded patch set 13 08/06/20, 08:08
-
TYPO3com voted on patch set 13 V +1 08/06/20, 08:22 Completed build in 13m 34s on Thu, 6 Aug, 08:22 AM Test Summary: 72963 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4433
-
Andreas Kienast uploaded patch set 14 08/08/20, 13:46
-
TYPO3com voted on patch set 14 V +1 08/08/20, 14:13 Completed build in 24m 39s on Sat, 8 Aug, 02:13 PM Test Summary: 72975 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4499
-
Andreas Kienast voted on patch set 14 V +1 CR +1 08/08/20, 16:03
-
Oliver Hader uploaded patch set 15 12/03/20, 19:53
-
TYPO3com voted on patch set 15 V +1 12/03/20, 20:03 Completed build in 09m 24s on Thu, 3 Dec, 08:03 PM Test Summary: 32407 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7767
-
Andreas Kienast commented on patch set 15 V +1 CR +1 12/04/20, 08:55
ActionDispatcher.ts:71I think we need some kind of a registry than can get extended from the "outside". We get more and more dependencies into this single module which is already loaded in the backend login but cannot be used anyway. However, this can be done later™.ImmediateActionElement.ts:38UnresolvedMy comment in ActionDispatcher.ts applies here as well.WindowManager.ts:21Would this work as well? public open = this.localOpen;Backend.ts:913UnresolvedHooray -
Andreas Kienast uploaded patch set 16 12/04/20, 13:55
-
Andreas Kienast voted on patch set 16 V +1 CR +1 12/04/20, 13:55
-
TYPO3com voted on patch set 16 V +1 12/04/20, 14:04 Completed build in 08m 53s on Fri, 4 Dec, 02:04 PM Test Summary: 32407 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7785
-
Oliver Hader commented on patch set 16 12/04/20, 17:05
ActionDispatcher.ts:71Reply UnresolvedYepp, was at this point as well... we "need" (could have) dependency injection for our "components" as well - in order to change/adjust those constraints in a flexible way (not necessarily with configuration). later™ or tomorrow's-problem™WindowManager.ts:21Reply UnresolvedMost probably due to scoping of `thisArg` and explicitly not using `this.localOpen.bind(this)` (that's the part I cannot remember in detail anymore) -
Benni Mack voted on patch set 16 V +2 CR +2 12/10/20, 11:39
-
Benni Mack merged patch set 17 12/10/20, 11:39
-
Markus Klein commented on patch set 17 12/12/20, 09:56
PageLayoutController.php:755regression: this is a string if you use SQLITE. -
Markus Klein commented on patch set 17 12/12/20, 10:01
PageLayoutController.php:755Reply -
Oliver Hader commented on patch set 17 12/13/20, 10:01
PageLayoutController.php:755ReplyDone