Review main Merged

64247[BUGFIX] Don't set default start module in UC explicitly

Andreas Kienast CR +2 V +2 Easy +0 −4 updated 04/20/20, 07:39

Commit message

The backend already provides the possibility for a backend user to use
the first available module as "start module". However, if the UC of
backend user is empty, its start module is set to "help_AboutAbout"
explicitly, which contradicts the mentioned feature. Additionally,
EXT:about is an optional dependency which may break the backend at this
point.

Because of the listed reasons, explicitly setting "help_AboutAbout" has
been removed as well as the override by EXT:dashboard.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Josef Glatz +1
    • Oli Bartsch +1
    • Markus Klein +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Josef Glatz +1
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1622

  1. Andreas Kienast uploaded patch set 1 04/19/20, 14:01

  2. Andreas Kienast updated the commit message in patch set 2 04/19/20, 14:02

  3. Susi Moog voted on patch set 2 CR +1 04/19/20, 14:10

  4. TYPO3com voted on patch set 1 V -1 04/19/20, 14:13 Completed build in 11m 26s on Sun, 19 Apr, 02:13 PM Test Summary: 71 of 74111 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2843

  5. TYPO3com voted on patch set 2 V -1 04/19/20, 14:18 Completed build in 16m 44s on Sun, 19 Apr, 02:18 PM Test Summary: 71 of 74111 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2844

  6. TYPO3com commented on patch set 2 04/19/20, 14:37 Completed build in 52m 26s on Sun, 19 Apr, 02:37 PM Test Summary: 71 of 74111 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2844

  7. Andreas Kienast commented on patch set 2 V -1 04/19/20, 14:50

    This patch needs an update in the testing framework
  8. Andreas Kienast uploaded patch set 3 04/19/20, 15:02

  9. Andreas Kienast voted on patch set 3 CR -2 04/19/20, 15:02

  10. TYPO3com voted on patch set 3 V +1 04/19/20, 15:14 Completed build in 11m 33s on Sun, 19 Apr, 03:14 PM Test Summary: 73627 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2845

  11. Susi Moog commented on patch set 3 04/20/20, 04:35

    and I think we should remove the line Richard mentioned, as otherwise as far as I can see this feature won't work again if the dashboard is installed (as the goal was to make the dashboard the auto-default it's not a problem because it will also be the first module available)
  12. Andreas Kienast uploaded patch set 4 04/20/20, 07:04

  13. Andreas Kienast voted on patch set 4 CR 0 04/20/20, 07:04

  14. TYPO3com voted on patch set 4 V +1 04/20/20, 07:17 Completed build in 12m 37s on Mon, 20 Apr, 07:17 AM Test Summary: 73627 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2870

  15. Richard Haeser updated the commit message in patch set 5 04/20/20, 07:27

  16. Richard Haeser voted on patch set 5 V +1 CR +1 04/20/20, 07:27

  17. Oli Bartsch voted on patch set 5 CR +1 04/20/20, 07:29

  18. Markus Klein voted on patch set 5 V +1 CR +1 04/20/20, 07:31

  19. Josef Glatz voted on patch set 5 V +1 CR +1 04/20/20, 07:38

  20. TYPO3com voted on patch set 5 V +1 04/20/20, 07:38 Completed build in 11m 18s on Mon, 20 Apr, 07:38 AM Test Summary: 73626 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2871

  21. Richard Haeser voted on patch set 5 V +2 CR +2 04/20/20, 07:39

  22. Richard Haeser merged patch set 6 04/20/20, 07:39