Review main Merged

64248[BUGFIX] Make widget group identifier unique

Chris Müller CR +2 V +2 Easy +2 −2 updated 04/19/20, 18:03

Commit message

In the "Add widget" dialog the id of the group tab was not unique.
This interfered with other ids in the backend. A prefix was added
to make it unique.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Björn Jacob +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Björn Jacob +1
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 79

  1. Chris Müller uploaded patch set 1 04/19/20, 15:07

  2. Chris Müller uploaded patch set 2 04/19/20, 15:14

  3. TYPO3com voted on patch set 1 V +1 04/19/20, 15:20 Completed build in 13m 20s on Sun, 19 Apr, 03:20 PM Test Summary: 73627 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2846

  4. TYPO3com voted on patch set 2 V +1 04/19/20, 15:26 Completed build in 11m 47s on Sun, 19 Apr, 03:26 PM Test Summary: 73627 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2847

  5. Andreas Kienast voted on patch set 2 V +1 CR +1 04/19/20, 15:43

  6. Björn Jacob commented on patch set 2 V +1 CR +1 04/19/20, 15:46

    Didn't see a warning before the patch tbh. But still works like a charm.
  7. Oli Bartsch voted on patch set 2 V +1 CR +1 04/19/20, 15:52

  8. Georg Ringer voted on patch set 2 V +2 CR +2 04/19/20, 18:03

  9. Georg Ringer merged patch set 3 04/19/20, 18:03