64250[BUGFIX] Fix check for skipping translation of the metadata file field
Commit message
Review
-
Code review CR +2 Done
- Susi Moog +2
- Daniel Goerz +1
- Tobi Kretschmann +1
- Oliver Hader +1
-
Verified V +2 Done
- Susi Moog +2
- Daniel Goerz +1
- TYPO3com +1 CI
Issues 2
Files 1
Review log 1821
-
Xavier Perseguers uploaded patch set 1 04/19/20, 16:11
-
Riccardo De Contardi commented on patch set 1 04/19/20, 16:22
after installing the patch I got this error: `Class 'TYPO3\CMS\Backend\Form\FormDataProvider\ExtensionManagementUtility' not found` -
TYPO3com voted on patch set 1 V -1 04/19/20, 16:22 Completed build in 11m 30s on Sun, 19 Apr, 04:22 PM Test Summary: 616 of 73459 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2850
-
Xavier Perseguers uploaded patch set 2 04/19/20, 18:06
-
TYPO3com voted on patch set 2 V +1 04/19/20, 18:18 Completed build in 12m 06s on Sun, 19 Apr, 06:18 PM Test Summary: 73627 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2854
-
Riccardo De Contardi commented on patch set 2 V +1 04/19/20, 19:49
Tested with status, fe_groups field -
Benni Mack voted on patch set 2 CR +1 04/19/20, 19:53
-
Daniel Goerz commented on patch set 2 CR -1 04/19/20, 20:47
TcaSelectItems.php:114Now that I am looking at this again, this seems also wrong. If we only want to skip the file field of the sys_file_metadata table (which is what the original patch intended to do) we should not include the $filemetadataIsLoaded but rather fix the condition to if (!($table === 'sys_file_metadata' && $fieldName === 'file')) or if ($table !== 'sys_file_metadata' || $fieldName !== 'file') -
Daniel Goerz commented on patch set 2 04/19/20, 20:48
Will look at this tomorrow again, too tired right now. -
Xavier Perseguers commented on patch set 2 04/20/20, 06:16
TcaSelectItems.php:114Reply UnresolvedThen yes, definitely the first alternative which is more obvious than the De Morgan 2nd form of the test. -
Daniel Goerz uploaded patch set 3 04/20/20, 08:22
-
Daniel Goerz voted on patch set 3 V +1 CR +1 04/20/20, 08:22
-
Tobi Kretschmann commented on patch set 3 04/20/20, 08:32
TcaSelectItems.php:111isn't this comment then superfluous -
TYPO3com voted on patch set 3 V +1 04/20/20, 08:33 Completed build in 11m 35s on Mon, 20 Apr, 08:33 AM Test Summary: 73627 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2873
-
Tobi Kretschmann commented on patch set 3 04/20/20, 08:33
nevermind. i read it wrong.TcaSelectItems.php:111ReplyDone -
Tobi Kretschmann voted on patch set 3 CR +1 04/20/20, 08:35
-
Susi Moog voted on patch set 3 V +1 CR +1 04/20/20, 08:39
-
Susi Moog voted on patch set 3 V +2 CR +2 04/20/20, 08:54
-
Susi Moog merged patch set 4 04/20/20, 08:55
-
Oliver Hader commented on patch set 4 CR +1 04/20/20, 09:05
TcaSelectItems.php:112looks correct now... boolean arithmetic in general: `!(A && B)` <=> `!A || !B` as well as `(!A && !B)` <=> `AA || B` -
Oliver Hader commented on patch set 4 04/20/20, 09:06
TcaSelectItems.php:112Reply UnresolvedDe Morgan Laws: https://en.wikipedia.org/wiki/De_Morgan%27s_laws