Review main Merged

64250[BUGFIX] Fix check for skipping translation of the metadata file field

Xavier Perseguers CR +2 V +2 Easy +1 −1 updated 04/20/20, 09:06

Commit message

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Daniel Goerz +1
    • Tobi Kretschmann +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Susi Moog +2
    • Daniel Goerz +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 1821

  1. Xavier Perseguers uploaded patch set 1 04/19/20, 16:11

  2. Riccardo De Contardi commented on patch set 1 04/19/20, 16:22

    after installing the patch I got this error: `Class 'TYPO3\CMS\Backend\Form\FormDataProvider\ExtensionManagementUtility' not found`
  3. TYPO3com voted on patch set 1 V -1 04/19/20, 16:22 Completed build in 11m 30s on Sun, 19 Apr, 04:22 PM Test Summary: 616 of 73459 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2850

  4. Xavier Perseguers uploaded patch set 2 04/19/20, 18:06

  5. TYPO3com voted on patch set 2 V +1 04/19/20, 18:18 Completed build in 12m 06s on Sun, 19 Apr, 06:18 PM Test Summary: 73627 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2854

  6. Riccardo De Contardi commented on patch set 2 V +1 04/19/20, 19:49

    Tested with status, fe_groups field
  7. Benni Mack voted on patch set 2 CR +1 04/19/20, 19:53

  8. Daniel Goerz commented on patch set 2 CR -1 04/19/20, 20:47

    TcaSelectItems.php:114

    Now that I am looking at this again, this seems also wrong. If we only want to skip the file field of the sys_file_metadata table (which is what the original patch intended to do) we should not include the $filemetadataIsLoaded but rather fix the condition to if (!($table === 'sys_file_metadata' && $fieldName === 'file')) or if ($table !== 'sys_file_metadata' || $fieldName !== 'file')
  9. Daniel Goerz commented on patch set 2 04/19/20, 20:48

    Will look at this tomorrow again, too tired right now.
  10. Xavier Perseguers commented on patch set 2 04/20/20, 06:16

    TcaSelectItems.php:114 Reply Unresolved

    Then yes, definitely the first alternative which is more obvious than the De Morgan 2nd form of the test.
  11. Daniel Goerz uploaded patch set 3 04/20/20, 08:22

  12. Daniel Goerz voted on patch set 3 V +1 CR +1 04/20/20, 08:22

  13. Tobi Kretschmann commented on patch set 3 04/20/20, 08:32

    TcaSelectItems.php:111

    isn't this comment then superfluous
  14. TYPO3com voted on patch set 3 V +1 04/20/20, 08:33 Completed build in 11m 35s on Mon, 20 Apr, 08:33 AM Test Summary: 73627 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2873

  15. Tobi Kretschmann commented on patch set 3 04/20/20, 08:33

    nevermind. i read it wrong.

    TcaSelectItems.php:111 Reply

    Done
  16. Tobi Kretschmann voted on patch set 3 CR +1 04/20/20, 08:35

  17. Susi Moog voted on patch set 3 V +1 CR +1 04/20/20, 08:39

  18. Susi Moog voted on patch set 3 V +2 CR +2 04/20/20, 08:54

  19. Susi Moog merged patch set 4 04/20/20, 08:55

  20. Oliver Hader commented on patch set 4 CR +1 04/20/20, 09:05

    TcaSelectItems.php:112

    looks correct now... boolean arithmetic in general: `!(A && B)` <=> `!A || !B` as well as `(!A && !B)` <=> `AA || B`
  21. Oliver Hader commented on patch set 4 04/20/20, 09:06

    TcaSelectItems.php:112 Reply Unresolved