64251[BUGFIX] Skip dynamically assigned instance names in extension scanner
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Ghanshyam Bhava +1
- Christian Eßl +1
- Benni Mack +1
-
Verified V +2 Done
- Oliver Hader +2
- Ghanshyam Bhava +1
- Christian Eßl +1
- Benni Mack +1
- TYPO3com +1 CI
Issues 1
Files 3
- typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/ConstructorArgumentMatcher.php2+2 −0
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/Fixtures/ConstructorArgumentMatcherFixture.php+2 −0
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/ConstructorArgumentMatcherTest.php+3 −3
Review log 1114
-
Oliver Hader uploaded patch set 1 04/19/20, 16:28
-
Oliver Hader updated the commit message in patch set 2 04/19/20, 16:31
-
TYPO3com voted on patch set 2 V -1 04/19/20, 16:41 Completed build in 10m 41s on Sun, 19 Apr, 04:41 PM Test Summary: 18 of 70820 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2852
-
TYPO3com commented on patch set 2 04/19/20, 16:56 Completed build in 35m 43s on Sun, 19 Apr, 04:56 PM Test Summary: 1 of 74111 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2852
-
Christian Eßl commented on patch set 2 04/19/20, 17:16
-
Oliver Hader updated the commit message in patch set 3 04/19/20, 18:44
-
Oliver Hader commented on patch set 3 04/19/20, 18:45
ConstructorArgumentMatcher.php:73Reply UnresolvedActually, it's okay... it shall only be skipped if the node is an object that does not have __toString() (cannot be casted to `(string)`)... -
TYPO3com voted on patch set 3 V +1 04/19/20, 18:55 Completed build in 11m 15s on Sun, 19 Apr, 06:55 PM Test Summary: 73627 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2855
-
Christian Eßl voted on patch set 3 V +1 CR +1 04/19/20, 18:56
-
Benni Mack voted on patch set 3 V +1 CR +1 04/19/20, 19:53
-
Ghanshyam Bhava voted on patch set 3 CR +1 04/19/20, 19:59
-
Ghanshyam Bhava voted on patch set 3 V +1 04/19/20, 19:59
-
Oliver Hader voted on patch set 3 V +2 CR +2 04/19/20, 19:59
-
Oliver Hader merged patch set 4 04/19/20, 19:59
ConstructorArgumentMatcher.php:73