Review main Merged

64251[BUGFIX] Skip dynamically assigned instance names in extension scanner

Oliver Hader CR +2 V +2 Easy +7 −3 updated 04/19/20, 19:59

Commit message

Dynamically created class instances using a variable name cannot be
resolved in extension scanner - given the fact that a class member
variable can change at any time and the scanner would have to keep
that state - which is too much for static code analysis.

Thus, the following source code is not analyzed.

$className = SomeClass::class;
$object = GeneralUtility($className);

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Ghanshyam Bhava +1
    • Christian Eßl +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Ghanshyam Bhava +1
    • Christian Eßl +1
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1114

  1. Oliver Hader uploaded patch set 1 04/19/20, 16:28

  2. Oliver Hader updated the commit message in patch set 2 04/19/20, 16:31

  3. TYPO3com voted on patch set 2 V -1 04/19/20, 16:41 Completed build in 10m 41s on Sun, 19 Apr, 04:41 PM Test Summary: 18 of 70820 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2852

  4. TYPO3com commented on patch set 2 04/19/20, 16:56 Completed build in 35m 43s on Sun, 19 Apr, 04:56 PM Test Summary: 1 of 74111 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2852

  5. Christian Eßl commented on patch set 2 04/19/20, 17:16

    ConstructorArgumentMatcher.php:73

    shouldn't this line be in an extra parenthesis?
  6. Oliver Hader updated the commit message in patch set 3 04/19/20, 18:44

  7. Oliver Hader commented on patch set 3 04/19/20, 18:45

    ConstructorArgumentMatcher.php:73 Reply Unresolved

    Actually, it's okay... it shall only be skipped if the node is an object that does not have __toString() (cannot be casted to `(string)`)...
  8. TYPO3com voted on patch set 3 V +1 04/19/20, 18:55 Completed build in 11m 15s on Sun, 19 Apr, 06:55 PM Test Summary: 73627 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2855

  9. Christian Eßl voted on patch set 3 V +1 CR +1 04/19/20, 18:56

  10. Benni Mack voted on patch set 3 V +1 CR +1 04/19/20, 19:53

  11. Ghanshyam Bhava voted on patch set 3 CR +1 04/19/20, 19:59

  12. Ghanshyam Bhava voted on patch set 3 V +1 04/19/20, 19:59

  13. Oliver Hader voted on patch set 3 V +2 CR +2 04/19/20, 19:59

  14. Oliver Hader merged patch set 4 04/19/20, 19:59