Review 9.5 Merged

64252[BUGFIX] Skip dynamically assigned instance names in extension scanner

Oliver Hader CR +2 V +2 Easy +9 −4 updated 04/28/20, 07:27

Commit message

Dynamically created class instances using a variable name cannot be
resolved in extension scanner - given the fact that a class member
variable can change at any time and the scanner would have to keep
that state - which is too much for static code analysis.

Thus, the following source code is not analyzed.

$className = SomeClass::class;
$object = GeneralUtility::makeInstance($className);

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 57

  1. Oliver Hader uploaded patch set 1 04/19/20, 20:04

  2. TYPO3com voted on patch set 1 V +1 04/19/20, 20:19 Completed build in 13m 41s on Sun, 19 Apr, 08:19 PM Test Summary: 74789 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-490

  3. Benni Mack voted on patch set 1 CR +1 04/23/20, 08:56

  4. Oliver Hader updated the commit message in patch set 2 04/25/20, 13:32

  5. TYPO3com voted on patch set 2 V +1 04/25/20, 13:46 Completed build in 14m 33s on Sat, 25 Apr, 01:46 PM Test Summary: 74813 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-522

  6. Oliver Hader voted on patch set 2 V +2 CR +2 04/28/20, 07:26

  7. Oliver Hader merged patch set 3 04/28/20, 07:27