Review main Merged

64255[TASK] Ensure TSFE is really a valid object

Markus Klein CR +2 V +2 Easy +1 −1 updated 04/20/20, 10:55

Commit message

Make sure the TSFE fetched in TemplateService really is a valid
TypoScriptFrontendController.
This way any kind of "fake Frontend" built in Backend does not
break the functionality.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Oliver Klee +1
    • Andreas Kienast +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 78

  1. Markus Klein uploaded patch set 1 04/20/20, 09:12

  2. Andreas Kienast voted on patch set 1 V +1 CR +1 04/20/20, 09:14

  3. Oliver Klee voted on patch set 1 CR +1 04/20/20, 09:17

  4. Oli Bartsch voted on patch set 1 V +1 CR +1 04/20/20, 09:17

  5. TYPO3com voted on patch set 1 V +1 04/20/20, 09:24 Completed build in 11m 54s on Mon, 20 Apr, 09:24 AM Test Summary: 73627 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2875

  6. Benni Mack voted on patch set 1 V +2 CR +2 04/20/20, 09:25

  7. Benni Mack merged patch set 2 04/20/20, 09:25

  8. Oliver Hader voted on patch set 2 CR +1 04/20/20, 10:55