Review main Merged

64257[BUGFIX] Resolve pid for records being pasted

Andreas Kienast CR +2 V +2 Easy +5 −4 updated 04/21/20, 06:37

Commit message

Pasted records use a negative integer to determine their location which
is passed as "pid". The DataHandler now resolves the real pid of the
records before executing any checks.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Wouter Wolters +1
    • Oliver Hader +1
    • Susi Moog +1
  • Verified V +2 Done
    • Benni Mack +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 1113

  1. Andreas Kienast uploaded patch set 1 04/20/20, 13:34

  2. Andreas Kienast commented on patch set 1 CR -1 04/20/20, 13:41

    Let's wait for tests first

    DataHandler.php:3269 Unresolved

    $realDestPid
  3. TYPO3com voted on patch set 1 V -1 04/20/20, 13:49 Completed build in 14m 46s on Mon, 20 Apr, 01:49 PM Test Summary: 93 of 74141 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2895

  4. Andreas Kienast commented on patch set 1 V -1 04/20/20, 13:53

    I'm checking a different solution
  5. Andreas Kienast uploaded patch set 2 04/20/20, 14:13

  6. TYPO3com voted on patch set 2 V +1 04/20/20, 14:29 Completed build in 15m 53s on Mon, 20 Apr, 02:29 PM Test Summary: 73657 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2899

  7. Wouter Wolters voted on patch set 2 CR +1 04/20/20, 18:31

  8. Benni Mack voted on patch set 2 CR +2 04/20/20, 18:38

  9. Benni Mack voted on patch set 2 V +1 04/20/20, 19:15

  10. Susi Moog voted on patch set 2 V +1 CR +1 04/21/20, 05:23

  11. Benni Mack voted on patch set 2 V +2 04/21/20, 06:35

  12. Benni Mack merged patch set 3 04/21/20, 06:35

  13. Oliver Hader voted on patch set 3 CR +1 04/21/20, 06:37