64260[BUGFIX] Display human-readable preview of FlexForm values
Commit message
Review
-
Code review CR +2 Done
- Nikita Hovratov +2
- Stefan Bürk +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Nikita Hovratov +2
- Stefan Bürk +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 12
- Build/Sources/Sass/component/_diff.scss2+1 −1
- typo3/sysext/backend/Classes/Controller/ContentElement/ElementHistoryController.php+14 −5
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+5 −1
- typo3/sysext/backend/Classes/View/ValueFormatter/FlexFormValueFormatter.phpnew+301 −0
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −1
- typo3/sysext/backend/Tests/Functional/View/ValueFormatter/Fixtures/FlexFormValueFormatter/Language/Locallang.xlfnew+39 −0
- typo3/sysext/backend/Tests/Functional/View/ValueFormatter/Fixtures/FlexFormValueFormatter/FlexFormDataStructure.xmlnew+98 −0
- typo3/sysext/backend/Tests/Functional/View/ValueFormatter/Fixtures/FlexFormValueFormatter/FlexFormValue.xmlnew+33 −0
- typo3/sysext/backend/Tests/Functional/View/ValueFormatter/Fixtures/FlexFormValueFormatter/ValuePreview.txtnew+22 −0
- typo3/sysext/backend/Tests/Functional/View/ValueFormatter/FlexFormValueFormatterTest.phpnew+96 −0
- typo3/sysext/workspaces/Classes/Controller/Remote/RemoteServer.php+14 −1
- typo3/sysext/workspaces/Classes/Service/HistoryService.php+13 −4
Review log 5688
Show 3863 earlier messages
-
Uwe Trotzek uploaded patch set 1 04/20/20, 14:46
-
TYPO3com voted on patch set 1 V -1 04/20/20, 15:01 Completed build in 14m 55s on Mon, 20 Apr, 03:01 PM Test Summary: 73660 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2904
-
Uwe Trotzek uploaded patch set 2 04/21/20, 05:23
-
TYPO3com voted on patch set 2 V -1 04/21/20, 05:25 Completed build in 01m 06s on Tue, 21 Apr, 05:25 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2934
-
Uwe Trotzek uploaded patch set 3 04/21/20, 05:44
-
TYPO3com voted on patch set 3 V +1 04/21/20, 05:58 Completed build in 14m 36s on Tue, 21 Apr, 05:58 AM Test Summary: 73676 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2936
-
Daniel Goerz wrote 10/09/20, 16:02
Topic set to workspaces -
Uwe Trotzek uploaded patch set 4 12/16/20, 10:41
-
TYPO3com voted on patch set 4 V -1 12/16/20, 10:42 Completed build in 22s on Wed, 16 Dec, 10:42 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8211
-
Benni Mack uploaded patch set 5 01/04/21, 13:26
-
TYPO3com voted on patch set 5 V -1 01/04/21, 13:27 Completed build in 21s on Mon, 4 Jan, 01:27 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8587
-
Andreas Kienast uploaded patch set 6 01/16/21, 10:33
-
Andreas Kienast commented on patch set 6 CR -1 01/16/21, 10:35
FlexFormValueProcessor.php:303Why do we need specific support for templavoila? Can we make this implementation more generic? -
TYPO3com voted on patch set 6 V +1 01/16/21, 10:42 Completed build in 09m 05s on Sat, 16 Jan, 10:42 AM Test Summary: 32578 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8875
-
Benni Mack commented on patch set 6 10/20/21, 15:55
IMHO this is not a feature, but a bugfix! -
Benni Mack uploaded patch set 7 10/21/21, 10:51
-
core-ci voted on patch set 7 V -1 10/21/21, 11:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18398
-
Benni Mack updated the commit message in patch set 8 11/18/21, 10:53
-
core-ci voted on patch set 8 V -1 11/18/21, 14:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19500
-
Benni Mack wrote 11/29/21, 10:17
Change destination moved from master to main -
Benni Mack updated the commit message in patch set 9 11/29/21, 14:08
-
core-ci voted on patch set 9 V -1 11/29/21, 18:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20104
-
Benjamin Franzke uploaded patch set 10 01/25/22, 14:58
-
core-ci voted on patch set 10 V +1 01/25/22, 15:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22527
-
Simon Schaufelberger uploaded patch set 11 03/22/22, 21:58
-
Simon Schaufelberger commented on patch set 11 03/22/22, 22:03
just a rebase with updated backend.css, no other changes -
core-ci voted on patch set 11 V +1 03/22/22, 22:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25058
-
Simon Schaufelberger commented on patch set 11 V +1 CR +1 03/22/22, 22:26
Looks much better than before! -
Simon Schaufelberger commented on patch set 11 03/22/22, 22:28
Reply
this can be easily tested with the styleguide flexform example -
Simon Schaufelberger uploaded patch set 12 04/07/22, 16:26
-
Simon Schaufelberger uploaded patch set 13 04/07/22, 16:27
-
Simon Schaufelberger voted on patch set 13 V +1 CR +1 04/07/22, 16:28
-
core-ci voted on patch set 13 V +1 04/07/22, 16:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25775
-
core-ci voted on patch set 12 V -1 04/07/22, 17:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25774
-
Simon Schaufelberger uploaded patch set 14 04/21/22, 18:34
-
Simon Schaufelberger voted on patch set 14 V +1 CR +1 04/21/22, 18:35
-
core-ci voted on patch set 14 V +1 04/21/22, 18:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26282
-
Simon Schaufelberger uploaded patch set 15 05/19/22, 22:49
-
Simon Schaufelberger voted on patch set 15 V +1 CR +1 05/19/22, 22:50
-
core-ci voted on patch set 15 V -1 05/19/22, 22:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27331
-
Simon Schaufelberger uploaded patch set 16 05/20/22, 19:37
-
core-ci voted on patch set 16 V -1 05/20/22, 19:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27358
-
Oliver Klee commented on patch set 16 05/20/22, 20:05
FlexFormValueProcessor.php:245You'll probably need to change the return type to this to get rid of the PHPStan warning: @return non-empty-string|null -
Simon Schaufelberger commented on patch set 16 05/20/22, 20:28
FlexFormValueProcessor.php:245ReplyThis worked! Thank you! -
Simon Schaufelberger uploaded patch set 17 05/20/22, 20:29
-
core-ci voted on patch set 17 V -1 05/20/22, 20:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27359
-
Oliver Klee commented on patch set 17 05/20/22, 20:55
_diff.scss:84You’ll also need to re-compile the CSS. (That’s the build failure AFAICS.) -
Simon Schaufelberger uploaded patch set 18 05/20/22, 21:44
-
Simon Schaufelberger commented on patch set 17 05/20/22, 21:44
_diff.scss:84ReplyDone -
core-ci voted on patch set 18 V +1 05/20/22, 21:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27360
-
Nikita Hovratov uploaded patch set 19 06/10/22, 14:41
-
core-ci voted on patch set 19 V +1 06/10/22, 14:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27927
-
Nikita Hovratov uploaded patch set 20 06/10/22, 15:21
-
core-ci voted on patch set 20 V -1 06/10/22, 15:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27932
-
Nikita Hovratov uploaded patch set 21 06/10/22, 15:35
-
Nikita Hovratov uploaded patch set 22 06/10/22, 15:38
-
core-ci voted on patch set 21 V -1 06/10/22, 15:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27934
-
core-ci voted on patch set 22 V -1 06/10/22, 15:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27935
-
core-ci commented on patch set 22 06/10/22, 15:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27935
-
core-ci voted on patch set 22 V +1 06/10/22, 16:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27935
-
Nikita Hovratov uploaded patch set 23 06/10/22, 19:00
-
core-ci voted on patch set 23 V -1 06/10/22, 19:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27947
-
Oliver Klee commented on patch set 23 06/10/22, 19:11
The test failure is unrelated and should be fixable with a rebase.
-
Nikita Hovratov uploaded patch set 24 06/10/22, 19:19
-
core-ci voted on patch set 24 V -1 06/10/22, 19:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27950
-
Nikita Hovratov rebased onto patch set 25 06/10/22, 19:29
-
core-ci voted on patch set 25 V +1 06/10/22, 19:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27951
-
Oliver Klee wrote 06/10/22, 19:40
Removed cc Oliver Klee. -
Nikita Hovratov uploaded patch set 26 06/10/22, 20:21
-
Nikita Hovratov commented on patch set 25 06/10/22, 20:21
FlexFormValueProcessor.php:303ReplyDone -
core-ci voted on patch set 26 V +1 06/10/22, 20:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27952
-
Nikita Hovratov commented on patch set 26 06/10/22, 20:32
Thanks for the really nice patch! I refactored a bit and added a few more tests. Also, I renamed the class to FlexFormValueFormatter as it fits better, what it does and so we don't get confused about the FlexFormProcessor. We still have a problem with diffs of FlexForms with more than one field inside a sheet. The DiffUtility breaks the formatting. This can be fixed by changing the granularity of finediff to "Character", but this is not possible right now. It is hard-coded to "Word". This means we first need a new feature, to change the granularity. Unfortunately this would mean we can't backport it to v11. Or if we do we knowingly include the bad formatted, but still a lot better diff. -
Nikita Hovratov uploaded patch set 27 06/10/22, 21:14
-
Nikita Hovratov commented on patch set 27 06/10/22, 21:16
As discussed with lolli, I'm using now the finediff directly to be able to choose the character granularity for flex values. -
Simon Schaufelberger voted on patch set 27 V +1 CR +1 06/10/22, 21:19
-
core-ci voted on patch set 27 V +1 06/10/22, 21:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27955
-
Jörg Bösche voted on patch set 27 CR +1 06/24/22, 19:30
-
Nikita Hovratov uploaded patch set 28 06/25/22, 11:26
-
core-ci voted on patch set 28 V +1 06/25/22, 11:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28411
-
Simon Schaufelberger uploaded patch set 29 07/05/22, 00:09
-
Simon Schaufelberger voted on patch set 29 V +1 CR +1 07/05/22, 00:10
-
core-ci voted on patch set 29 V +1 07/05/22, 00:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28645
-
Simon Schaufelberger uploaded patch set 30 07/08/22, 13:09
-
Simon Schaufelberger voted on patch set 30 V +1 CR +1 07/08/22, 13:09
-
core-ci voted on patch set 30 V +1 07/08/22, 13:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28756
-
Stefan Bürk voted on patch set 30 V +1 CR +1 07/08/22, 20:38
-
Nikita Hovratov voted on patch set 30 V +2 CR +2 07/08/22, 20:55
-
Nikita Hovratov merged patch set 31 07/08/22, 20:57