Review main Merged

64261[BUGFIX] Allow be.container ViewHelper without Base Header Bar

Benni Mack CR +2 V +2 Easy +8 −0 updated 04/20/20, 19:46

Commit message

Due to the replacment of DocumentTemplate with ModuleTemplate
the rendering is now different. In order to overcome this,
a new flag enableDocHeader is added.

see https://review.typo3.org/c/Packages/TYPO3.CMS/+/63290

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Wouter Wolters +1
    • Tymoteusz Motylewski +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Tymoteusz Motylewski +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 811

  1. Benni Mack uploaded patch set 1 04/20/20, 15:14

  2. TYPO3com voted on patch set 1 V +1 04/20/20, 15:32 Completed build in 16m 39s on Mon, 20 Apr, 03:32 PM Test Summary: 73657 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2908

  3. Benni Mack uploaded patch set 2 04/20/20, 18:19

  4. Benni Mack updated the commit message in patch set 3 04/20/20, 18:20

  5. Wouter Wolters voted on patch set 3 CR +1 04/20/20, 18:26

  6. Georg Ringer voted on patch set 3 V +1 CR +1 04/20/20, 18:27

  7. TYPO3com voted on patch set 2 V -1 04/20/20, 18:33 Completed build in 14m 00s on Mon, 20 Apr, 06:33 PM Test Summary: 1 of 73490 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2916

  8. TYPO3com voted on patch set 3 V +1 04/20/20, 18:39 Completed build in 19m 40s on Mon, 20 Apr, 06:39 PM Test Summary: 73657 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2917

  9. Tymoteusz Motylewski voted on patch set 3 V +1 CR +1 04/20/20, 19:38

  10. Benni Mack voted on patch set 3 V +2 CR +2 04/20/20, 19:46

  11. Benni Mack merged patch set 4 04/20/20, 19:46