Review main Merged

64264[BUGFIX] Properly initialize backend user base state in middlewares

Oliver Hader CR +2 V +2 Easy +17 −10 updated 06/05/20, 14:05

Commit message

Due to the fact that backend user objects have not been initialized
properly in PSR-15 middlewares defining the current in-memory state
for workspaces falls back to the users' default workspace.

Basically `BackendUserAuthentication::groupData['workspace_perms']`
was not initialized which results in the mentioned behavior for
non-admin users.

`fetchGroupData` was split up into public `initializeGroupData`
to be used internally only and protected `enrichGroupData`.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Tobi Kretschmann +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Hader +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1318

  1. Oliver Hader uploaded patch set 1 04/20/20, 17:42

  2. TYPO3com voted on patch set 1 V -1 04/20/20, 17:42 Completed build in 25s on Mon, 20 Apr, 05:42 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2914

  3. Oliver Hader commented on patch set 1 04/20/20, 17:43

    → currently requires bugfix https://review.typo3.org/c/Packages/TYPO3.CMS/+/64259 as well
  4. Oliver Hader uploaded patch set 2 04/20/20, 17:43

  5. TYPO3com voted on patch set 2 V -1 04/20/20, 17:58 Completed build in 13m 58s on Mon, 20 Apr, 05:58 PM Test Summary: 73202 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2915

  6. TYPO3com voted on patch set 2 V +1 04/20/20, 18:05 Completed build in 34m 54s on Mon, 20 Apr, 06:05 PM Test Summary: 73657 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2915

  7. Oliver Hader voted on patch set 2 CR -1 04/20/20, 18:25

  8. Tymoteusz Motylewski commented on patch set 2 04/20/20, 18:26

    BackendUserAuthentication.php:2220

    This looks like a debigging statement?
  9. Benni Mack uploaded patch set 3 04/20/20, 18:51

  10. TYPO3com voted on patch set 3 V +1 04/20/20, 19:03 Completed build in 11m 32s on Mon, 20 Apr, 07:03 PM Test Summary: 73657 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2918

  11. Oliver Hader uploaded patch set 4 04/20/20, 19:09

  12. Oliver Hader voted on patch set 4 V +1 04/20/20, 19:10

  13. Oliver Hader commented on patch set 4 04/20/20, 19:13

    BackendUserAuthentication.php:2220 Reply Unresolved

    Yepp, forgot to remove it... the output was used at https://forge.typo3.org/issues/90954#note-4
  14. TYPO3com voted on patch set 4 V +1 04/20/20, 19:26 Completed build in 15m 01s on Mon, 20 Apr, 07:26 PM Test Summary: 73655 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2921

  15. Tobi Kretschmann voted on patch set 4 CR +1 04/20/20, 19:35

  16. Benni Mack voted on patch set 4 V +2 CR +2 04/20/20, 19:59

  17. Benni Mack merged patch set 5 04/20/20, 19:59

  18. Benni Mack commented on patch set 5 06/05/20, 14:05

    won't do a backport, as this would be much more complicated