64265[BUGFIX] Properly allow multiline values in Install Tool
Commit message
Review
-
Code review CR +2 Done
- Anja Leichsenring +2
- Christian Kuhn +1
-
Verified V +2 Done
- Anja Leichsenring +2
- Christian Kuhn +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1013
-
Georg Ringer uploaded patch set 1 04/20/20, 19:03
-
Georg Ringer commented on patch set 1 04/20/20, 19:03
This change is ready for review. -
TYPO3com voted on patch set 1 V -1 04/20/20, 19:15 Completed build in 11m 32s on Mon, 20 Apr, 07:14 PM Test Summary: 73657 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2919
-
Tymoteusz Motylewski commented on patch set 1 04/20/20, 19:15
is this just for v10? -
Tymoteusz Motylewski commented on patch set 1 04/20/20, 19:18
looks like a real error ------ ------------------------------------------------------------ 20-Apr-2020 19:04:42 Line install/Classes/Service/LocalConfigurationValueService.php 20-Apr-2020 19:04:42 ------ ------------------------------------------------------------ 20-Apr-2020 19:04:42 194 Variable $valueHasChanged might not be defined. 20-Apr-2020 19:04:42 ------ ------------------------------------------------------------ 20-Apr-2020 19:04:42 20-Apr-2020 19:04:42 [ERROR] Found 1 error -
TYPO3com commented on patch set 1 04/20/20, 19:48 Completed build in 56m 38s on Mon, 20 Apr, 07:48 PM Test Summary: 73657 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2919
-
Benni Mack commented on patch set 1 04/20/20, 20:10
this would actually remove the line feeds, if I read the code correctly? -
Benni Mack updated the commit message in patch set 2 05/25/20, 18:47
-
Christian Kuhn uploaded patch set 3 08/18/20, 17:00
-
Christian Kuhn commented on patch set 3 V +1 CR +1 08/18/20, 17:01
Fixed that changed values are not saved ... Functional tests on this class wouldn't be bad, but I think this change is still good to go. -
TYPO3com voted on patch set 3 V +1 08/18/20, 17:11 Completed build in 11m 26s on Tue, 18 Aug, 05:11 PM Test Summary: 72998 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4762
-
Anja Leichsenring voted on patch set 3 V +2 CR +2 08/18/20, 18:30
-
Anja Leichsenring merged patch set 4 08/18/20, 18:30