Review main Merged

64267[BUGFIX] Ensure ZipService sets proper permissions recursively

Benni Mack CR +2 V +2 Easy +1 −1 updated 04/21/20, 06:49

Commit message

ZipService->extract was introduced for a security patch set
but the permissions are not set correctly, as fixPermissions
receives a directory with a slash at the end, resulting
in "//" for recursive checks.

This patch fixes the issue.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Danilo Caccialanza +1
    • Guido Schmechel +1
    • Tymoteusz Motylewski +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Danilo Caccialanza +1
    • Tymoteusz Motylewski +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 78

  1. Benni Mack uploaded patch set 1 04/20/20, 19:09

  2. TYPO3com voted on patch set 1 V +1 04/20/20, 19:30 Completed build in 19m 29s on Mon, 20 Apr, 07:30 PM Test Summary: 73657 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2922

  3. Tymoteusz Motylewski voted on patch set 1 V +1 CR +1 04/20/20, 19:59

  4. Andreas Kienast voted on patch set 1 CR +1 04/21/20, 06:08

  5. Danilo Caccialanza commented on patch set 1 V +1 CR +1 04/21/20, 06:22

    Yes problem exist and patch works correctly.
  6. Guido Schmechel voted on patch set 1 CR +1 04/21/20, 06:44

  7. Andreas Kienast voted on patch set 1 V +2 CR +2 04/21/20, 06:49

  8. Andreas Kienast merged patch set 2 04/21/20, 06:49