Review main Merged

64270[BUGFIX] Fix wrongly used typecast in combination with ?? operator

Thomas Pronold CR +2 V +2 Easy +5 −5 updated 04/21/20, 07:39

Commit message

The 'else' part would never be returned in this cases.

Used [a-zA-Z0-9]{3,}\)[^(]?\$.*\?\? to find the cases.
Care, this brings up false positives as well.

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Andreas Kienast +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Susi Moog +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 78

  1. Thomas Pronold uploaded patch set 1 04/21/20, 07:12

  2. TYPO3com voted on patch set 1 V +1 04/21/20, 07:28 Completed build in 16m 05s on Tue, 21 Apr, 07:28 AM Test Summary: 73657 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2942

  3. Andreas Kienast voted on patch set 1 CR +1 04/21/20, 07:34

  4. Andreas Kienast voted on patch set 1 V +1 04/21/20, 07:35

  5. Susi Moog voted on patch set 1 V +1 CR +1 04/21/20, 07:36

  6. Susi Moog voted on patch set 1 V +2 CR +2 04/21/20, 07:37

  7. Susi Moog merged patch set 2 04/21/20, 07:37

  8. Oliver Hader voted on patch set 2 CR +1 04/21/20, 07:39