Review 9.5 Merged

64272[BUGFIX] Fix wrongly used typecast in combination with ?? operator

Susi Moog CR +2 V +2 Easy +2 −2 updated 04/21/20, 11:47

Commit message

The 'else' part would never be returned in this cases.

Used [a-zA-Z0-9]{3,}\)[^(]?\$.*\?\? to find the cases.
Care, this brings up false positives as well.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Alexander Schnitzler +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Alexander Schnitzler +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 811

  1. Susi Moog commented on patch set 1 04/21/20, 07:41

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/core/Classes/TypoScript/TemplateService.php * typo3/sysext/linkvalidator/Classes/EventListener/CheckBrokenRteLinkEventListener.php * typo3/sysext/setup/Classes/Controller/SetupModuleController.php
  2. TYPO3com voted on patch set 1 V -1 04/21/20, 07:41 Completed build in 21s on Tue, 21 Apr, 07:41 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-498

  3. Susi Moog uploaded patch set 2 04/21/20, 07:48

  4. Susi Moog updated the commit message in patch set 3 04/21/20, 07:49

  5. Susi Moog commented on patch set 3 04/21/20, 07:49

    This change is ready for review.
  6. TYPO3com voted on patch set 3 V -1 04/21/20, 08:01 Completed build in 12m 07s on Tue, 21 Apr, 08:01 AM Test Summary: 12 of 75389 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-500

  7. Alexander Schnitzler commented on patch set 3 V +1 CR +1 04/21/20, 08:38

    No matter what bamboo says, I say this is right. ^^
  8. TYPO3com voted on patch set 3 V +1 04/21/20, 08:44 Completed build in 1h 07m 15s on Tue, 21 Apr, 08:44 AM Test Summary: 74789 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-500

  9. Oliver Klee voted on patch set 3 CR +1 04/21/20, 11:31

  10. Georg Ringer voted on patch set 3 V +2 CR +2 04/21/20, 11:47

  11. Georg Ringer merged patch set 4 04/21/20, 11:47