Review 9.5 Merged

64273[BUGFIX] Prevent PageTypeDecorator from matching index too generously

Benni Mack CR +2 V +2 Normal +73 −1 updated 04/21/20, 13:11

Commit message

Pages that have slugs that end with the configured index
are now no longer matched falsely by the PageTypeDecorator.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 57

  1. Benni Mack commented on patch set 1 04/21/20, 10:17

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/frontend/Tests/Functional/SiteHandling/Fixtures/SlugScenario.yaml
  2. Benni Mack commented on patch set 2 04/21/20, 10:18

    Published edit on patch set 1.
  3. Benni Mack commented on patch set 2 04/21/20, 10:18

    This change is ready for review.
  4. TYPO3com voted on patch set 1 V -1 04/21/20, 10:31 Completed build in 13m 57s on Tue, 21 Apr, 10:31 AM Test Summary: 3705 of 75407 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-501

  5. TYPO3com voted on patch set 2 V +1 04/21/20, 10:34 Completed build in 16m 07s on Tue, 21 Apr, 10:34 AM Test Summary: 74807 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-502

  6. Benni Mack voted on patch set 2 V +2 CR +2 04/21/20, 13:11

  7. Benni Mack merged patch set 3 04/21/20, 13:11