Review 9.5 Merged

64274[BUGFIX] Throw BadRequestException on failed hmac validation from forms

Benni Mack CR +2 V +2 Easy +39 −2 updated 04/28/20, 07:39

Commit message

If a HMAC of a submitted form is invalid (because it has been tampered
with), TYPO3 would previously throw an exception that leads to a
status code 500. This is incorrect behaviour, as the error comes from
bad user input and not a server error.

In case the HMAC of a submitted form is invalid, both extbase and
ext:form will now throw a BadRequestException, which will then lead to
a status code 400 (BAD REQUEST).

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 711

  1. Benni Mack commented on patch set 1 04/21/20, 10:19

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/extbase/Classes/Mvc/Controller/MvcPropertyMappingConfigurationService.php * typo3/sysext/extbase/Tests/Unit/Mvc/Controller/MvcPropertyMappingConfigurationServiceTest.php
  2. TYPO3com voted on patch set 1 V -1 04/21/20, 10:19 Completed build in 20s on Tue, 21 Apr, 10:19 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-503

  3. Benni Mack uploaded patch set 2 04/28/20, 07:16

  4. Benni Mack commented on patch set 2 04/28/20, 07:17

    This change is ready for review.
  5. TYPO3com voted on patch set 2 V -1 04/28/20, 07:17 Completed build in 21s on Tue, 28 Apr, 07:17 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-534

  6. Benni Mack uploaded patch set 3 04/28/20, 07:21

  7. Benni Mack uploaded patch set 4 04/28/20, 07:22

  8. TYPO3com voted on patch set 3 V -1 04/28/20, 07:25 Completed build in 01m 19s on Tue, 28 Apr, 07:25 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-535

  9. TYPO3com voted on patch set 4 V +1 04/28/20, 07:38 Completed build in 15m 02s on Tue, 28 Apr, 07:38 AM Test Summary: 74828 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-536

  10. Benni Mack voted on patch set 4 V +2 CR +2 04/28/20, 07:39

  11. Benni Mack merged patch set 5 04/28/20, 07:39