Review 9.5 Merged

64280[BUGFIX] Remove $scheme from LegacyLinkNotationConverter::resolve()

Benni Mack CR +2 V +2 Easy +2 −8 updated 04/21/20, 13:10

Commit message

The code block using $scheme is never reached, because there is already
an elseif condition further above, that is true for all urls containing
":".

The last else block even states in the comment:
"special handling without a scheme"

Therefore the variable is removed to remove a bit of complexity from the
function.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Benni Mack commented on patch set 1 04/21/20, 12:42

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 04/21/20, 13:00 Completed build in 17m 44s on Tue, 21 Apr, 01:00 PM Test Summary: 74786 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-511

  3. Benni Mack voted on patch set 1 V +2 CR +2 04/21/20, 13:10

  4. Benni Mack merged patch set 2 04/21/20, 13:10