Review 9.5 Merged

64284[BUGFIX] Fix extension scanner Index.rst filename parsing

Benni Mack CR +2 V +2 Easy +10 −8 updated 04/28/20, 06:18

Commit message

Rst files may not contain issue numbers. The extension scanner
iterates all .rst files (including Index.rst) which cases a type
error for typo3/sysext/core/Documentation/Changelog/7.0/Index.rst

(1/1) TypeError
Return value of
TYPO3\CMS\Install\UpgradeAnalysis\DocumentationFile::parseIssueId()
must be of the type string, null returned

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Josef Glatz +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Josef Glatz +1
    • TYPO3com +1 CI

Issues 2

Files 2

Review log 78

  1. Benni Mack commented on patch set 1 04/23/20, 08:53

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/install/Resources/Private/Partials/Upgrade/UpgradeDocs/PanelItem.html
  2. Benni Mack uploaded patch set 2 04/28/20, 06:02

  3. Benni Mack commented on patch set 2 04/28/20, 06:02

    This change is ready for review.
  4. Josef Glatz voted on patch set 2 CR +1 04/28/20, 06:14

  5. TYPO3com voted on patch set 2 V +1 04/28/20, 06:16 Completed build in 14m 21s on Tue, 28 Apr, 06:16 AM Test Summary: 74822 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-531

  6. Josef Glatz voted on patch set 2 V +1 04/28/20, 06:17

  7. Benjamin Franzke commented on patch set 2 V +2 CR +2 04/28/20, 06:17

    Tested under v9, so you don't have to, Benni. Will merge once Bamboo is happy.
  8. Benjamin Franzke merged patch set 3 04/28/20, 06:18