Review 9.5 Merged

64286[BUGFIX] Do not disable caching for caches with TransientMemoryBackend

Benjamin Franzke CR +2 V +2 Easy +2 −1 updated 04/27/20, 16:32

Commit message

If caching is disabled in the CacheManager, caches using the
TransientMemoryBackend are not adjusted to NullBackend anymore.

This mainly affects the runtime cache, which is memory-based anyways
and should be a "forget after the request"-cache.

This also fixes a PDOException in the page slug update wizard when
using PostgreSQL, as the Install Tool is using the core in "no-cache"
mode. (See entry point of the Install Tool)

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Stephan Großberndt +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Stephan Großberndt +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 56

  1. Benjamin Franzke commented on patch set 1 04/27/20, 15:42

    Cherry Picked from branch master.
  2. Benjamin Franzke voted on patch set 1 V +1 CR +1 04/27/20, 15:47

  3. TYPO3com voted on patch set 1 V +1 04/27/20, 15:54 Completed build in 12m 03s on Mon, 27 Apr, 03:54 PM Test Summary: 74822 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-523

  4. Stephan Großberndt voted on patch set 1 V +1 CR +1 04/27/20, 16:01

  5. Benjamin Franzke voted on patch set 1 V +2 CR +2 04/27/20, 16:31

  6. Benjamin Franzke merged patch set 2 04/27/20, 16:32