Review 9.5 Merged

64290[BUGFIX] Fix inline icon rendering of bitmap icons

Benni Mack CR +2 V +2 Easy +6 −7 updated 04/28/20, 08:14

Commit message

The existing "inline" rendering for icons causes bitmaps to be
rendered for SVG-inline usage using the <image> tag. This tag
can not be rendered in HTML context.

The backend module menu uses inlined SVGs. Rendering bitmap icons with
SVG-syntax, without an SVG root element, does not work in this context.
(Note: It works in SVG trees because the optional svg container is
removed by SvgTree.js and the image-tag is wrapped into a new <g> element)

We do now wrap "inline" bitmap icons into an svg tag, which will fix
the bitmap module case while the bitmap icons will still
be embeddable into svg groups (<g>) for svg trees.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • TYPO3com +1 CI

Issues 2

Files 2

Review log 35

  1. Benni Mack commented on patch set 1 04/28/20, 07:28

    Cherry Picked from branch master.
  2. Benjamin Franzke voted on patch set 1 V +2 CR +2 04/28/20, 07:43

  3. TYPO3com voted on patch set 1 V -1 04/28/20, 07:58 Completed build in 18m 45s on Tue, 28 Apr, 07:58 AM Test Summary: 1 of 75422 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-537

  4. TYPO3com voted on patch set 1 V +1 04/28/20, 08:13 Completed build in 52m 27s on Tue, 28 Apr, 08:13 AM Test Summary: 74820 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-537

  5. Benni Mack merged patch set 2 04/28/20, 08:14