Review main Merged

64293[BUGFIX] Add missing type cast to support sqlite

Daniel Siepmann CR +2 V +2 Easy +2 −2 updated 04/21/20, 20:57

Commit message

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Josef Glatz +1
    • Oli Bartsch +1
    • Oliver Klee +1
    • Wouter Wolters +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Josef Glatz +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1114

  1. Daniel Siepmann uploaded patch set 1 04/21/20, 11:35

  2. TYPO3com voted on patch set 1 V -1 04/21/20, 11:35 Completed build in 24s on Tue, 21 Apr, 11:35 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2947

  3. Benjamin Franzke commented on patch set 1 04/21/20, 11:42

    RecordRememberer.php:35

    Missing parentheses, typecast has higher priority than the null-coalescing operator. This will raise a "PHP notice: Undefined index: uid" Should rather be $this->rememberRecordUid((int)($record['uid'] ?? 0));
  4. Daniel Siepmann uploaded patch set 2 04/21/20, 11:43

  5. Daniel Siepmann commented on patch set 2 04/21/20, 11:44

    RecordRememberer.php:35 Reply

    Done
  6. Benni Mack voted on patch set 2 CR +1 04/21/20, 11:46

  7. TYPO3com voted on patch set 2 V -1 04/21/20, 11:54 Completed build in 11m 00s on Tue, 21 Apr, 11:54 AM Test Summary: 1 of 74141 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2948

  8. Oli Bartsch voted on patch set 2 CR +1 04/21/20, 12:04

  9. Josef Glatz voted on patch set 2 V +1 CR +1 04/21/20, 12:12

  10. Oliver Klee voted on patch set 2 CR +1 04/21/20, 13:49

  11. TYPO3com voted on patch set 2 V +1 04/21/20, 18:44 Completed build in 11m 37s on Tue, 21 Apr, 06:44 PM Test Summary: 73657 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2956

  12. Wouter Wolters voted on patch set 2 CR +1 04/21/20, 20:42

  13. Benjamin Franzke voted on patch set 2 V +2 CR +2 04/21/20, 20:57

  14. Benjamin Franzke merged patch set 3 04/21/20, 20:57