Review main Merged

64299[DOCS] Update rte_ckeditor documentation for 10.4 LTS release

Josef Glatz CR +2 V +2 Hard +145 −171 updated 04/22/20, 07:24

Commit message

Use newer formating, e.g.:

* Definition lists for better readability.
* Content directive to automatically update local TOC.
  To not update by hand.
* Use short :: for yaml examples.
  To shorten rst code and make it more readable.
* Use option directive to highlight options.
* Update intersphinx urls to not trigger redirects.

Always use YAML instead of yaml or Yaml.
Use inline Fluid example, instead of adding it with another tip.
Update Includes.txt to match current state and provide expected css
classes and text roles.

Review

  • Code review CR +2 Done
    • Daniel Siepmann +2
    • Josef Glatz +1
  • Verified V +2 Done
    • Daniel Siepmann +2
    • Josef Glatz +1

Issues 1

Files 10

Review log 913

  1. Josef Glatz uploaded patch set 1 04/21/20, 19:55

  2. Josef Glatz commented on patch set 1 04/21/20, 19:55

    here we go
  3. TYPO3com voted on patch set 1 V +1 04/21/20, 20:07 Completed build in 11m 47s on Tue, 21 Apr, 08:07 PM Test Summary: 73657 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2961

  4. Daniel Siepmann uploaded patch set 2 04/22/20, 06:04

  5. TYPO3com voted on patch set 2 V -1 04/22/20, 06:16 Completed build in 12m 10s on Wed, 22 Apr, 06:16 AM Test Summary: 2 of 74141 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2964

  6. TYPO3com voted on patch set 2 V +1 04/22/20, 06:40 Completed build in 48m 36s on Wed, 22 Apr, 06:40 AM Test Summary: 73657 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2964

  7. Josef Glatz commented on patch set 3 04/22/20, 07:07

    Published edit on patch set 2.
  8. Josef Glatz rebased onto patch set 4 04/22/20, 07:07

  9. Josef Glatz commented on patch set 5 04/22/20, 07:08

    Published edit on patch set 4.
  10. Josef Glatz commented on patch set 5 V +1 CR +1 04/22/20, 07:11

    Thanks Daniel! Nice to see how your changes improves the readability! For the reviewers: if somebody needs help for local rendering documentation: get in touch, we are happy to help ツ
  11. Daniel Siepmann voted on patch set 5 V +2 CR +2 04/22/20, 07:21

  12. Daniel Siepmann merged patch set 6 04/22/20, 07:21

  13. TYPO3com voted on patch set 3 V +1 04/22/20, 07:24 Completed build in 16m 56s on Wed, 22 Apr, 07:24 AM Test Summary: 73657 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2965