Review main Merged

64302[TASK] Deprecate BackendUtility::viewOnClick

Oliver Hader CR +2 V +2 Normal +67 −25 updated 05/20/21, 20:52

Commit message

Core invocations of BackendUtility::viewOnClick() have
been removed with issue #91123 in v10 to reduce the amount
of inline JavaScript.
The method can be deprecated in v11 now.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Markus Klein +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Markus Klein +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 8

Review log 2127

Show 2 earlier messages
  1. Oliver Hader uploaded patch set 1 04/22/20, 09:31

  2. Oliver Hader marked it work in progress 04/22/20, 09:31

  1. TYPO3com voted on patch set 1 V -1 04/22/20, 09:32 Completed build in 21s on Wed, 22 Apr, 09:32 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2977

  2. Oliver Hader commented on patch set 1 04/22/20, 09:32

    → only when 10.4 Git branch has been created, thus this changeset is for 11.x-dev
  3. Georg Ringer commented on patch set 1 04/22/20, 12:40

    BackendUtility.php:2371

    typo there + add a @deprecated tag as well to get better IDE support
  4. Oliver Hader uploaded patch set 2 07/15/20, 22:13

  5. TYPO3com voted on patch set 2 V -1 07/15/20, 22:13 Completed build in 24s on Wed, 15 Jul, 10:13 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4107

  6. Oliver Hader uploaded patch set 3 07/15/20, 22:15

  7. TYPO3com voted on patch set 3 V -1 07/15/20, 22:16 Completed build in 20s on Wed, 15 Jul, 10:16 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4108

  8. Oliver Hader commented on patch set 3 07/15/20, 22:16

    BackendUtility.php:2371 Reply Unresolved

    Thx, @deprecated available in PHPdoc for static function already
  9. Oliver Hader updated the commit message in patch set 4 07/15/20, 22:18

  10. TYPO3com voted on patch set 4 V -1 07/15/20, 22:19 Completed build in 19s on Wed, 15 Jul, 10:19 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4109

  11. Oliver Hader commented on patch set 4 07/15/20, 22:19

  12. Christian Kuhn commented on patch set 4 05/20/21, 17:16

    ping. we could easily un-wip and finish this one, right?
  13. Oliver Hader commented on patch set 4 05/20/21, 17:21

  14. Christian Kuhn uploaded patch set 5 05/20/21, 20:07

  15. core-ci voted on patch set 5 V +1 05/20/21, 20:21 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11746

  16. Benni Mack marked it ready for review 05/20/21, 20:28

  17. Benni Mack voted on patch set 5 V +1 CR +1 05/20/21, 20:28

  18. Markus Klein commented on patch set 5 CR -1 05/20/21, 20:42

    Deprecation-91806-BackendUtilityViewOnClick.rst:35

    in in
  19. Markus Klein commented on patch set 6 05/20/21, 20:42

    Published edit on patch set 5.
  20. Markus Klein voted on patch set 6 V +1 CR +1 05/20/21, 20:42

  21. Christian Kuhn commented on patch set 6 05/20/21, 20:47

    Deprecation-91806-BackendUtilityViewOnClick.rst:35 Reply

    thx.
  22. Benni Mack voted on patch set 6 V +1 CR +1 05/20/21, 20:49

  23. core-ci voted on patch set 6 V +1 05/20/21, 20:51 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11748

  24. Christian Kuhn voted on patch set 6 V +2 CR +2 05/20/21, 20:51

  25. Christian Kuhn merged patch set 7 05/20/21, 20:52