Review main Merged

64304[BUGFIX] Check if $conf['tags.'] is array in ContentObjectRenderer

Christian Eßl CR +2 V +2 Easy +1 −1 updated 04/28/20, 08:37

Commit message

If a html comment is placed in a fluid template at a position, that
gets parsed by lib.parseFunc_RTE and no "tags" configuration exists for
the parsefunc, a php warning is thrown, because it was not checked if
$conf['tags.'] is an actual array.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Josef Glatz +1
    • Oliver Klee +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Benni Mack +2
    • Josef Glatz +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 912

  1. Christian Eßl uploaded patch set 1 04/22/20, 11:40

  2. Josef Glatz updated the commit message in patch set 2 04/22/20, 11:50

  3. TYPO3com voted on patch set 1 V +1 04/22/20, 11:56 Completed build in 15m 30s on Wed, 22 Apr, 11:56 AM Test Summary: 73657 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2985

  4. TYPO3com voted on patch set 2 V -1 04/22/20, 12:02 Completed build in 11m 55s on Wed, 22 Apr, 12:02 PM Test Summary: 1 of 74141 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2986

  5. Oliver Hader commented on patch set 2 CR +1 04/22/20, 12:08

    ContentObjectRenderer.php:3934 Unresolved

    could be `$conf['tags.'] ?? []` as well... however, I don't have a strong opinion on that
  6. TYPO3com voted on patch set 2 V +1 04/22/20, 12:10 Completed build in 32m 05s on Wed, 22 Apr, 12:10 PM Test Summary: 73657 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2986

  7. Josef Glatz voted on patch set 2 V +1 CR +1 04/22/20, 12:57

  8. Josef Glatz commented on patch set 2 04/22/20, 13:07

    I’ve tested it without declaring any lib.parseFunc config. Is this the only case, right?
  9. Oliver Klee voted on patch set 2 CR +1 04/22/20, 15:05

  10. Oliver Klee commented on patch set 2 04/22/20, 15:05

    Unresolved

    Is 9.5 affected as well?
  11. Benni Mack voted on patch set 2 V +2 CR +2 04/28/20, 08:37

  12. Benni Mack merged patch set 3 04/28/20, 08:37